Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If using full pooling, eta should have dimension 0 #189

Open
wwiecek opened this issue Dec 20, 2024 · 1 comment
Open

If using full pooling, eta should have dimension 0 #189

wwiecek opened this issue Dec 20, 2024 · 1 comment

Comments

@wwiecek
Copy link
Owner

wwiecek commented Dec 20, 2024

In rubin_full it doesn't seem to, which wastes compute & space at least and may mess up convergence too

@wwiecek
Copy link
Owner Author

wwiecek commented Dec 21, 2024

You can probably also remove eta_baseline when pooling_baseline == 0, but with some re=interpretation of parameters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant