Fix some visual issues with spans.

Author: wyhaines

VERSION

@@ -1 +1 @@
-0.2.2
+0.2.3

shard.yml

@@ -1,5 +1,5 @@
 name: opentelemetry-instrumentation
-version: 0.2.2
+version: 0.2.3
 
 authors:
   - Kirk Haines <[email protected]>

spec/instrumentation/crystal_http_server_spec.cr

@@ -60,7 +60,7 @@ describe HTTP::Server, tags: ["HTTP::Server"] do
     traces[0]["resource"]["service.version"].should eq "1.0.0"
     traces[0]["spans"][0]["attributes"]["net.peer.ip"].should eq "127.0.0.1"
 
-    traces[1]["spans"][0]["name"].should eq "HTTP Request Received"
+    traces[1]["spans"][0]["name"].should eq "GET /"
     traces[1]["spans"][0]["attributes"]["http.method"].should eq "GET"
     traces[1]["spans"][0]["attributes"]["http.scheme"].should eq "http"
 

src/opentelemetry/instrumentation/crystal/http_server.cr

@@ -104,11 +104,10 @@ unless_enabled?("OTEL_CRYSTAL_DISABLE_INSTRUMENTATION_HTTP_SERVER") do
                   max_headers_size: max_headers_size,
                 )
 
+                break unless request
                 trace = OpenTelemetry.trace
-                trace.in_span("HTTP Request Received") do |span|
-                  # EOF
-                  break unless request
-
+                trace_name = request.is_a?(HTTP::Request) ? "#{request.method} #{request.path}" : "ERROR #{request.code}"
+                trace.in_span(trace_name) do |span|
                   response.reset
 
                   if request.is_a?(HTTP::Status)
@@ -171,6 +170,7 @@ unless_enabled?("OTEL_CRYSTAL_DISABLE_INSTRUMENTATION_HTTP_SERVER") do
                     return
                   end
                 end
+                break unless request
                 break unless request.as(HTTP::Request).keep_alive?
 
                 # Don't continue if the handler set `Connection` header to `close`