Refactor level section indexing

Author: xCollateral

src/main/java/net/vulkanmod/render/chunk/RenderSection.java

@@ -245,7 +245,7 @@ public BuildTask createCompileTask(RenderRegionBuilder renderRegionCache) {
         Level level = WorldRenderer.getLevel();
         int secX = xOffset >> 4;
         int secZ = zOffset >> 4;
-        int secY = (yOffset - level.getMinBuildHeight()) >> 4;
+        int secY = yOffset >> 4;
 
         if (!ChunkStatusMap.INSTANCE.chunkRenderReady(secX, secZ))
             return null;

src/main/java/net/vulkanmod/render/chunk/build/RenderRegion.java

@@ -42,13 +42,11 @@ public class RenderRegion implements BlockAndTintGetter {
     private TintCache tintCache;
 
     private final Map<BlockPos, BlockEntity> blockEntityMap;
-    private final int minHeight;
 
     private final Function<BlockPos, BlockState> blockStateGetter;
 
     RenderRegion(Level level, int x, int y, int z, PalettedContainer<BlockState>[] blockData, DataLayer[][] lightData, Map<BlockPos, BlockEntity> blockEntityMap) {
         this.level = level;
-        this.minHeight = level.getMinBuildHeight();
 
         this.minSecX = x - 1;
         this.minSecY = y - 1;
@@ -144,7 +142,7 @@ public LevelLightEngine getLightEngine() {
 
     public int getBrightness(LightLayer lightLayer, BlockPos blockPos) {
         int secX = SectionPos.blockToSectionCoord(blockPos.getX()) - this.minSecX;
-        int secY = SectionPos.blockToSectionCoord(blockPos.getY() - minHeight) - this.minSecY;
+        int secY = SectionPos.blockToSectionCoord(blockPos.getY()) - this.minSecY;
         int secZ = SectionPos.blockToSectionCoord(blockPos.getZ()) - this.minSecZ;
 
         DataLayer dataLayer = this.lightData[getSectionIdx(secX, secY, secZ)][lightLayer.ordinal()];
@@ -154,7 +152,7 @@ public int getBrightness(LightLayer lightLayer, BlockPos blockPos) {
 
     public int getRawBrightness(BlockPos blockPos, int i) {
         int secX = SectionPos.blockToSectionCoord(blockPos.getX()) - this.minSecX;
-        int secY = SectionPos.blockToSectionCoord(blockPos.getY() - minHeight) - this.minSecY;
+        int secY = SectionPos.blockToSectionCoord(blockPos.getY()) - this.minSecY;
         int secZ = SectionPos.blockToSectionCoord(blockPos.getZ()) - this.minSecZ;
 
         DataLayer[] dataLayers = this.lightData[getSectionIdx(secX, secY, secZ)];
@@ -199,7 +197,7 @@ public int getBlockIdx(int x, int y, int z) {
     }
 
     public BlockState defaultBlockState(BlockPos blockPos) {
-        return blockData[getBlockIdx(blockPos.getX(), blockPos.getY() - minHeight, blockPos.getZ())];
+        return blockData[getBlockIdx(blockPos.getX(), blockPos.getY(), blockPos.getZ())];
     }
 
     public BlockState debugBlockState(BlockPos blockPos) {

src/main/java/net/vulkanmod/render/chunk/build/RenderRegionBuilder.java

@@ -22,7 +22,7 @@ public class RenderRegionBuilder {
     public RenderRegion createRegion(Level level, int secX, int secY, int secZ) {
         LevelChunk levelChunk = getLevelChunk(level, secX, secZ);
         var sections = levelChunk.getSections();
-        LevelChunkSection section = sections[secY];
+        LevelChunkSection section = sections[level.getSectionIndexFromSectionY(secY)];
 
         if(section == null || section.hasOnlyAir())
             return null;
@@ -47,7 +47,8 @@ public RenderRegion createRegion(Level level, int secX, int secY, int secZ) {
                 sections = levelChunk1.getSections();
 
                 for(int y = minSecY; y <= maxSecY; ++y) {
-                    section = y >= 0 && y < sections.length ? sections[y] : null;
+                    int sectionIdx = y - minHeightSec;
+                    section = sectionIdx >= 0 && sectionIdx < sections.length ? sections[sectionIdx] : null;
 
                     final int relX = (x - minSecX), relY = (y - minSecY), relZ = (z - minSecZ);
                     final int idx = (relY * RenderRegion.WIDTH + relZ) * RenderRegion.WIDTH + relX;
@@ -56,7 +57,7 @@ public RenderRegion createRegion(Level level, int secX, int secY, int secZ) {
 
                     blockData[idx] = values;
 
-                    SectionPos pos = SectionPos.of(x, y + minHeightSec, z);
+                    SectionPos pos = SectionPos.of(x, y, z);
                     DataLayer[] dataLayers = getSectionDataLayers(level, pos);
 
                     lightData[idx] = dataLayers;