Skip to content

mode='remote' + dropdownAllowAll enabled and selected >> total changes we should keep currentPerPage to -1 #968

Open
@julius-spudvilas

Description

@julius-spudvilas

Expected Behavior
When dropdownAllowAll enabled + selected and total changes we should keep currentPerPage to -1

Actual Behavior
The currentPerPage is set to the total results value and that breaks the pagination dropdown as such option does not exists

Steps to Reproduce the Problem
Set dropdownAllowAll to true
Use mode='remote'
Get some resuts in table lets say 10
Then update results to anything else, let say 5
Pagination perPage dropdown breaks as:
after total changes the currentPerPage value is set to 5 and 5 is not available option in rowsPerPageOptions

Solution:
https://github.com/xaksis/vue-good-table/blob/889962c5b67f5bb621caa0a9bf0b3852d4199235/src/components/pagination/VgtPagination.vue#L146C65-L146C65
line 146 should also check that currentPerPage is NOT -1

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions