Urlencoded User-Agent string force closes (crashes) Kodi (Windows x64)

[enerdude]

When I for example have a m3u file containing the following and opening it in kodi via the video main menu item:

#EXTINF:-1, Video item
#KODIPROP:inputstream=inputstream.ffmpegdirect
#KODIPROP:mimetype=video/mp2t
#KODIPROP:inputstream.ffmpegdirect.is_realtime_stream=true
http://example.com/stream/stream.ts

or same using a random custom user agent header

#EXTINF:-1, Video item
#KODIPROP:inputstream=inputstream.ffmpegdirect
#KODIPROP:mimetype=video/mp2t
#KODIPROP:inputstream.ffmpegdirect.is_realtime_stream=true
http://example.com/stream/stream.ts|User-Agent=otg/1.5.1 (AppleTv Apple TV 4; tvOS16.0; appletv.client) libcurl/7.58.0 OpenSSL/1.0.2o zlib/1.2.11 clib/1.8.56

...both plays fine.

HOWEVER using same as above but urlencoding the User-Agent will force close (crash) kodi:

#EXTINF:-1, Video item
#KODIPROP:inputstream=inputstream.ffmpegdirect
#KODIPROP:mimetype=video/mp2t
#KODIPROP:inputstream.ffmpegdirect.is_realtime_stream=true
http://example.com/stream/stream.ts|User-Agent=otg%2F1.5.1%20%28AppleTv%20Apple%20TV%204%3B%20tvOS16.0%3B%20appletv.client%29%20libcurl%2F7.58.0%20OpenSSL%2F1.0.2o%20zlib%2F1.2.11%20clib%2F1.8.56

I am using Kodi 22 Alpha 1 however this issue seems related to an older issue that is still open albeit in my case it is not a specific string in the user-agent causing the crash. So I assume it affects Kodi versions 20 and up?
The issue I am talking about is #229

Edit: the crash issue is only present on my Windows x64 system ; my Android armv7 works fine

[phunkyfish]

Unfortunately we never found a solution to this bug.

[enerdude]

Unfortunately we never found a solution to this bug.

Ok but for my own purposes building my m3u files I can just use the normal (non urlencoded) strings, correct?

[phunkyfish]

Correct

[matthuisman]

assume this is the same issue as #229

[matthuisman]

got a windows debug env setup and got it to crash with traceback

However, seems i might need a debug build of the addon itself?

I tried to build with: make-addons.bat inputstream.ffmpegdirect
But keep getting the below error

[phunkyfish]

Yes, you’ll need a debug build of the addon.

I don’t suppose you can get debug in make addons.bat?

[matthuisman]

I had edited the build-addons to pass in Debug instead of Release.
But still got the above error :(

Trying now to build manually:

cmake -T host=x64 -G "Visual Studio 17 2022" -DADDONS_TO_BUILD=inputstream.ffmpegdirect -DCMAKE_BUILD_TYPE=Debug -DADDON_SRC_PREFIX=../.. -DPACKAGE_ZIP=1 ../../kodi/cmake/addons
cmake --build . --config Debug --target package-inputstream.ffmpegdirect

Will report back..

Same error, but found a bit more info above

Chat GPT says

Ill try that - i suspect this is something that should be installed by the build scripts - but maybe missed ?

[phunkyfish]

We install strawberry perl for windows as a dependency in the addon build system. Maybe look at the build log and see if there was an issue with that.

But you are correct, that should be done for you as part of the build.

[matthuisman]

i think the perl that comes with git for windows was getting picked up
Have removed that and will retry

As when i tried the perl.exe in the ffmpeg direct bin dir - it works fine with that MakeText

[phunkyfish]

Cool

[matthuisman]

That was it,

my User env path had C:\Program Files\Git\usr\bin in it
That has a bunch of exes including "perl"
So the build script would have been trying to use that perl (instead of strawberryperl)

Removed that above path from my env variables and built again

-- perl Configure VC-WIN64A disable-capieng;enable-static-engine;no-asm;no-dso;no-shared;no-tests;no-ui-console --pre
fix=C:/Users/Matt/inputstream.ffmpegdirect/build/build/depends

Got past the above part now, but then still:
NMAKE : fatal error U1073: don't know how to make 'build_generated' [C:\Users\Matt\inputstream.ffmpegdirect\build\build
\openssl\src\openssl-build\openssl.vcxproj]

Hmmmm
Cant see any other errors

Oops, had edits the deps.txt when i was debugging original issue.
Putting that back to original and trying again... (please....)

Same error - bugger :(
Might have to give up for now

[matthuisman]

Looks like fdf2728
removed the

find_package(StrawberryPerl REQUIRED)
set(ENV{PATH} "${STRAWBERRYPERL_PATH};$ENV{PATH}")

Ill try add that back in

That may have fixed my original issue as it look like it puts strawberryperl first

Aha - getting much more action now :)

I can PR adding the above back into the patch
PR up: #325

[matthuisman]

latest issue with manual build is ffmpeg fails to find libxml2

I looked at my PRs build and see
https://jenkins.kodi.tv/blue/organizations/jenkins/xbmc%2Finputstream.ffmpegdirect/detail/PR-325/5/pipeline/290
"Found LibXml2: C:/jenkws/workspace/binary-addons/kodi-windows-x86_64-Piers/cmake/addons/output/lib/libxml2.lib (found version "2.11.7") "

Manual build doesnt generate any sort of .lib.
Appears Kodi creates the above earlier on in the process (install-dependencies?)

So, i've now switched back to make-addons.bat and just changed the URL in kodi cmake for the add-on to point to my branch.

Hopefully finally get a build :)