Skip to content

Do some speedup stuff again #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 19, 2025
Merged

Do some speedup stuff again #49

merged 4 commits into from
May 19, 2025

Conversation

xd009642
Copy link
Owner

Two performance regressions I should probably figure out (maybe just system noise though)

Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 7.8s, or reduce sample count to 60.
coverage mapping        time:   [77.426 ms 79.072 ms 81.046 ms]                             
                        change: [+6.2990% +8.8096% +11.628%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
  1 (1.00%) high mild
  10 (10.00%) high severe

Benchmarking report generation: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 81.9s, or reduce sample count to 10.
report generation       time:   [806.43 ms 809.27 ms 812.17 ms]                              
                        change: [-79.923% -79.433% -78.921%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking subreport generation: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 12.1s, or reduce sample count to 40.
subreport generation    time:   [117.87 ms 119.28 ms 120.84 ms]                                 
                        change: [-22.306% -21.266% -20.132%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
  9 (9.00%) high mild
  4 (4.00%) high severe

     Running benches/profdata_parsing.rs (target/release/deps/profdata_parsing-734518ffb23e545c)
Gnuplot not found, using plotters backend
profdata_parse_cargo    time:   [18.734 ms 19.136 ms 19.613 ms]                                 
                        change: [-22.091% -20.090% -17.694%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
  3 (3.00%) high mild
  9 (9.00%) high severe

     Running benches/profraw_parsing.rs (target/release/deps/profraw_parsing-e56fea141cf59082)
Gnuplot not found, using plotters backend
Benchmarking profraw_parse_tokio: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.3s, or reduce sample count to 90.
profraw_parse_tokio     time:   [52.722 ms 53.620 ms 54.631 ms]                                
                        change: [-19.963% -18.530% -16.749%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 17 outliers among 100 measurements (17.00%)
  3 (3.00%) low mild
  8 (8.00%) high mild
  6 (6.00%) high severe

Benchmarking profraw_parse_cargo: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.0s, or reduce sample count to 60.
profraw_parse_cargo     time:   [77.907 ms 78.564 ms 79.221 ms]                                
                        change: [-17.393% -16.352% -15.324%] (p = 0.00 < 0.05)
                        Performance has improved.

     Running benches/report_merging.rs (target/release/deps/report_merging-adf23cc85e45e627)
Gnuplot not found, using plotters backend
Benchmarking merge: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 23.1s, or reduce sample count to 20.
merge                   time:   [272.11 ms 279.45 ms 286.81 ms]                  
                        change: [-1.3100% +1.8348% +4.4074%] (p = 0.19 > 0.05)
                        No change in performance detected.

Benchmarking big_merge: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 1104.2s, or reduce sample count to 10.
big_merge               time:   [9.8762 s 10.127 s 10.370 s]                         
                        change: [+6.5407% +10.084% +13.882%] (p = 0.00 < 0.05)
                        Performance has regressed.

xd009642 added 4 commits May 16, 2025 13:57
This favours deeper nodes in the expression tree meaning less unresolved
expressions and less iterations through the entire expression tree.
@xd009642 xd009642 merged commit 9f6a1b5 into master May 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant