[minor] DRY-ing up resource subclasses a bit

Author: Brandon Black

bin/twitter-ads

@@ -10,9 +10,11 @@ import atexit
 
 try:
     import twitter_ads
+    print('[INFO] using pip installed twitter-ads.')
 except ImportError:
     sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
     import twitter_ads
+    print('[INFO] using local clone of twitter-ads.')
 
 from twitter_ads.client import Client
 

twitter_ads/account.py

@@ -33,6 +33,10 @@ def __init__(self, client):
     def client(self):
         return self._client
 
+    @property
+    def account(self):
+        return NotImplementedError
+
     @classmethod
     def load(klass, client, id, **kwargs):
         """Returns an object instance for a given resource."""

twitter_ads/audience.py

@@ -13,13 +13,6 @@ class TailoredAudience(Resource):
     RESOURCE_UPDATE = '/0/accounts/{account_id}/tailored_audience_changes'
     OPT_OUT = '/0/accounts/{account_id}/tailored_audiences/global_opt_out'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
     @classmethod
     def create(klass, account, file_path, name, list_type):
         raise NotImplementedError

twitter_ads/campaign.py

@@ -13,13 +13,6 @@ class TargetingCriteria(Resource, Persistence):
     RESOURCE_COLLECTION = '/0/accounts/{account_id}/targeting_criteria'
     RESOURCE = '/0/accounts/{account_id}/targeting_criteria/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
     @classmethod
     def all(klass, account, line_item_id, **kwargs):
         """Returns a Cursor instance for a given resource."""
@@ -51,13 +44,6 @@ class FundingInstrument(Resource, Persistence):
     RESOURCE_COLLECTION = '/0/accounts/{account_id}/funding_instruments'
     RESOURCE = '/0/accounts/{account_id}/funding_instruments/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
 # funding instrument properties
 # read-only
 resource_property(FundingInstrument, 'id', readonly=True)
@@ -78,13 +64,6 @@ class PromotableUser(Resource):
     RESOURCE_COLLECTION = '/0/accounts/{account_id}/promotable_users'
     RESOURCE = '/0/accounts/{account_id}/promotable_users/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
 # promotable user properties
 # read-only
 resource_property(PromotableUser, 'id', readonly=True)
@@ -100,13 +79,6 @@ class AppList(Resource, Persistence):
     RESOURCE_COLLECTION = '/0/accounts/{account_id}/app_lists'
     RESOURCE = '/0/accounts/{account_id}/app_lists/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
     def create(self, name, *ids):
         if isinstance(ids, list):
             ids = ','.join(map(str, ids))
@@ -135,13 +107,6 @@ class Campaign(Resource, Persistence):
     RESOURCE_STATS = '/0/stats/accounts/{account_id}/campaigns'
     RESOURCE = '/0/accounts/{account_id}/campaigns/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
 # campaign properties
 # read-only
 resource_property(Campaign, 'id', readonly=True)
@@ -168,13 +133,6 @@ class LineItem(Resource, Persistence, Analytics):
     RESOURCE_STATS = '/0/stats/accounts/{account_id}/line_items'
     RESOURCE = '/0/accounts/{account_id}/line_items/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
     def targeting_criteria(self, id=None, **kwargs):
         """
         Returns a collection of targeting criteria available to the
@@ -218,7 +176,7 @@ class Tweet(object):
     TWEET_CREATE = '/0/accounts/{account_id}/tweet'
 
     def __init__(self):
-        raise StandardError(
+        raise NotImplementedError(
             'Error! {name} cannot be instantiated.'.format(name=self.__class__.__name__))
 
     @classmethod

twitter_ads/creative.py

@@ -13,13 +13,6 @@ class PromotedAccount(Resource, Persistence):
     RESOURCE_STATS = '/0/stats/accounts/{account_id}/promoted_accounts'
     RESOURCE = '/0/accounts/{account_id}/promoted_accounts/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
 # promoted account properties
 # read-only
 resource_property(PromotedAccount, 'id', readonly=True)
@@ -39,13 +32,6 @@ class PromotedTweet(Resource, Persistence, Analytics):
     RESOURCE_STATS = '/0/stats/accounts/{account_id}/promoted_tweets'
     RESOURCE = '/0/accounts/{account_id}/promoted_tweets/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
     def save(self):
         """
         Saves or updates the current object instance depending on the
@@ -87,13 +73,6 @@ class Video(Resource, Persistence):
     RESOURCE_COLLECTION = '/0/accounts/{account_id}/videos'
     RESOURCE = '/0/accounts/{account_id}/videos/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
 # video properties
 # read-only
 resource_property(Video, 'id', readonly=True)
@@ -116,13 +95,6 @@ class WebsiteCard(Resource, Persistence):
     RESOURCE_COLLECTION = '/0/accounts/{account_id}/cards/website'
     RESOURCE = '/0/accounts/{account_id}/cards/website/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
 # website card properties
 # read-only
 resource_property(WebsiteCard, 'id', readonly=True)
@@ -143,13 +115,6 @@ class LeadGenCard(Resource, Persistence):
     RESOURCE_COLLECTION = '/0/accounts/{account_id}/cards/lead_gen'
     RESOURCE = '/0/accounts/{account_id}/cards/lead_gen/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
 # lead gen card properties
 # read-only
 resource_property(LeadGenCard, 'id', readonly=True)
@@ -178,13 +143,6 @@ class AppDownloadCard(Resource, Persistence):
     RESOURCE_COLLECTION = '/0/accounts/{account_id}/cards/app_download'
     RESOURCE = '/0/accounts/{account_id}/cards/app_download/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
 # app download card properties
 # read-only
 resource_property(AppDownloadCard, 'id', readonly=True)
@@ -211,13 +169,6 @@ class ImageAppDownloadCard(Resource, Persistence):
     RESOURCE_COLLECTION = '/0/accounts/{account_id}/cards/image_app_download'
     RESOURCE = '/0/accounts/{account_id}/cards/image_app_download/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
 # image app download card properties
 # read-only
 resource_property(ImageAppDownloadCard, 'id', readonly=True)
@@ -243,13 +194,6 @@ class VideoAppDownloadCard(Resource, Persistence):
     RESOURCE_COLLECTION = '/0/accounts/{account_id}/cards/video_app_download'
     RESOURCE = '/0/accounts/{account_id}/cards/video_app_download/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
 # video app download card properties
 # read-only
 resource_property(VideoAppDownloadCard, 'id', readonly=True)
@@ -278,13 +222,6 @@ class ImageConversationCard(Resource, Persistence):
     RESOURCE_COLLECTION = '/0/accounts/{account_id}/cards/image_conversation'
     RESOURCE = '/0/accounts/{account_id}/cards/image_conversation/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
 # image conversation card properties
 # read-only
 resource_property(ImageConversationCard, 'id', readonly=True)
@@ -309,13 +246,6 @@ class VideoConversationCard(Resource, Persistence):
     RESOURCE_COLLECTION = '/0/accounts/{account_id}/cards/video_conversation'
     RESOURCE = '/0/accounts/{account_id}/cards/video_conversation/{id}'
 
-    def __init__(self, account):
-        self._account = account
-
-    @property
-    def account(self):
-        return self._account
-
 # video conversation card properties
 # read-only
 resource_property(VideoConversationCard, 'id', readonly=True)

twitter_ads/resource.py

@@ -31,6 +31,13 @@ class Resource(object):
 
     PROPERTIES = {}
 
+    def __init__(self, account):
+        self._account = account
+
+    @property
+    def account(self):
+        return self._account
+
     def from_response(self, response):
         """
         Populates a given objects attributes from a parsed JSON API response.