Skip to content

Add pgraph test goldens #21

Open
Open
@mborgerson

Description

@mborgerson
Member
  • Currently pgraph test results are not being checked against anything. Need to add expected images for comparison.
  • Need to deploy perceptual diff tool to Windows

Activity

changed the title [-]Add pgraph goldens[/-] [+]Add pgraph test goldens[/+] on Mar 22, 2022
abaire

abaire commented on Mar 23, 2022

@abaire
Contributor

https://gist.github.com/abaire/f566977419b3b3eb0537d3b4246de22f is a script I cobbled together to validate the CI results against the HW results. For any diffs that are found (there are no perceptual diffs in the current CI results) we can look at the diff output and decide if it's close enough to bless or if it's bugworthy.

To use, extract the CI results into sibling dirs, then pull https://github.com/abaire/nxdk_pgraph_tests_golden_results into the same dir. I used a symlink in my temp script and called it hw, see hw_dir in the script and adjust as necessary.

I created the script on macOS, I think on linux the perceptualdiff binary uses -- prefixed option names, so some minor adjustment may be necessary to get it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @mborgerson@abaire

        Issue actions

          Add pgraph test goldens · Issue #21 · xemu-project/xemu-test