Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xendit php library too bloated #176

Open
erikdemarco opened this issue Feb 15, 2022 · 3 comments
Open

Xendit php library too bloated #176

erikdemarco opened this issue Feb 15, 2022 · 3 comments

Comments

@erikdemarco
Copy link

erikdemarco commented Feb 15, 2022

When we compare xendit's php library with doku or midtrans here:
https://github.com/PTNUSASATUINTIARTHA-DOKU/jokul-php-library
https://github.com/Midtrans/midtrans-php

We have many disadvantage compared to them:
-) very huge filesize (1MB zipped with all composer required library), doku only <10kb, midtrans only <30kb (core library). So currently we are the most bloated, maybe we can make it modular so dev can include only the feature they need. Reduced complexity will make this library more easier to mantain.
-) Other library doesnt force to use composer to install it. They work out of the box without any need for other dependency.

Even our official xendit woocommerce plugin dont want to use this library, they build their own. If our own developer dont want to use this library, do you think other developer will use this? Just let it seep inside our head for a day.

Most developer when look how complicated this library compared with the other library for the same category will stay away from using this library.

@AaEzha
Copy link

AaEzha commented Jul 6, 2022

I think the simplest solution is you just don't use this package. Instead you can use POST/GET directly.

@4RSIM3R
Copy link

4RSIM3R commented Oct 13, 2022

Okay, I think the idea makes this SDK more modular, ie: maybe splitting it into specific domains like xendit-php-ewallets etc is good.

@erikdemarco
Copy link
Author

erikdemarco commented Oct 13, 2022

I think the simplest solution is you just don't use this package. Instead you can use POST/GET directly.

This is the problem. No one is using this repo because of this mindset.

Lets do a basic research on github. Lets compare usage of xendit-php and midtrans-php. Lets search for unique keyword on each project.

Midtrans (1K)
https://github.com/search?q=%22SNAP_PRODUCTION_BASE_URL%22&type=code

Xendit (1):
https://github.com/search?q=%22receiptNotificationReqParams%22&type=code

As you can see based on just a basic research like this we can conclude the usage rate of this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants