Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model names in DemogSelModels are unclear #11

Open
RyanGutenkunst opened this issue Apr 8, 2022 · 2 comments
Open

Model names in DemogSelModels are unclear #11

RyanGutenkunst opened this issue Apr 8, 2022 · 2 comments

Comments

@RyanGutenkunst
Copy link
Collaborator

The _sel and _sel_single_gamma suffixes aren't very informative. For models with a single gamma, _one_s might suffice. But for models with two gammas it's more complex, because one could incorporate those gammas into the models in multiple ways. Currently, we only have the case where s is equal in pop 1 and the ancestral pop, and different in pop 2. Any suggestions for what that should be referred to as?

@tjstruck
Copy link
Collaborator

Do we want to add to the Cache2D_mod.py class to include defining the most closely related population to the ancestral population and then have it sort out gamma1 vs. gamma2 based on pop IDs rather than defining more models?

@RyanGutenkunst
Copy link
Collaborator Author

I don't think so. That will be restrictive if we want to (for example) include more complex models in which selection depends on time, not just population. (I'm interested in recent data on time varying selection in drosophila.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants