fixes to build using GCC13 (#446)

* fixes to build using GCC13
* fix potential build error on GCC14
* use GCC 13.2 for CI
* add explanation of disabling compiler forloop bounds checks

Author: maks

Diff for: .github/workflows/build.yml

@@ -25,7 +25,7 @@ jobs:
       uses: carlosperate/arm-none-eabi-gcc-action@v1
       id: arm-none-eabi-gcc-action
       with:
-        release: 12.3.Rel1
+        release: 13.2.Rel1
     - run: arm-none-eabi-gcc --version
 
     - name: Create Build Environment for ILI9341

Diff for: sources/Adapters/picoTracker/main/picoTrackerMain.cpp

@@ -8,6 +8,16 @@
 #include "tusb.h"
 #include <System/Console/Trace.h>
 
+// this prevents a really annoying linker warning due to newlib and >gcc13
+// ref:
+// https://github.com/raspberrypi/pico-sdk/issues/1768#issuecomment-2649260970
+#ifdef __cplusplus
+extern "C" {
+int _getentropy(void *buffer, size_t length) { return -1; }
+}
+#endif
+// ================
+
 int main(int argc, char *argv[]) {
 
   // Initialise microcontroller specific hardware

Diff for: sources/Application/Views/DeviceView.cpp

@@ -157,7 +157,7 @@ void DeviceView::ProcessButtonMask(unsigned short mask, bool pressed) {
   if (!pressed)
     return;
 
-  FieldView::ProcessButtonMask(mask);
+  FieldView::ProcessButtonMask(mask, pressed);
 
   if (mask & EPBM_NAV) {
     if (mask & EPBM_DOWN) {

Diff for: sources/Application/Views/FieldView.cpp

@@ -43,7 +43,7 @@ void FieldView::Redraw() {
   };
 };
 
-void FieldView::ProcessButtonMask(unsigned short mask) {
+void FieldView::ProcessButtonMask(unsigned short mask, bool pressed) {
 
   if (focus_ == 0) {
     focus_ = *fieldList_.begin();

Diff for: sources/Application/Views/FieldView.h

@@ -10,7 +10,7 @@ class FieldView : public ScreenView {
   FieldView(GUIWindow &w, ViewData *viewData);
 
   virtual void Redraw();
-  virtual void ProcessButtonMask(unsigned short mask);
+  virtual void ProcessButtonMask(unsigned short mask, bool pressed) override;
 
   void SetFocus(UIField *);
   UIField *GetFocus();

Diff for: sources/Application/Views/InstrumentView.cpp

@@ -682,7 +682,7 @@ void InstrumentView::ProcessButtonMask(unsigned short mask, bool pressed) {
     viewMode_ = VM_NORMAL;
   }
 
-  FieldView::ProcessButtonMask(mask);
+  FieldView::ProcessButtonMask(mask, pressed);
 
   // EDIT Modifier
   if (mask & EPBM_EDIT) {

Diff for: sources/Application/Views/ProjectView.cpp

@@ -201,7 +201,7 @@ void ProjectView::ProcessButtonMask(unsigned short mask, bool pressed) {
   if (!pressed)
     return;
 
-  FieldView::ProcessButtonMask(mask);
+  FieldView::ProcessButtonMask(mask, pressed);
 
   if (mask & EPBM_NAV) {
     if (mask & EPBM_DOWN) {

Diff for: sources/Externals/SdFat/src/common/ArduinoFiles.h

@@ -53,6 +53,15 @@ class PrintFile : public print_t, public BaseFile {
   size_t write(uint8_t b) {
     return BaseFile::write(&b, 1);
   }
+  
+  /** Write multiple bytes.
+   * \param[in] buffer pointer to data to be written.
+   * \param[in] size number of bytes to write.
+   * \return number of bytes written.
+   */
+  virtual size_t write(const uint8_t* buffer, size_t size) override {
+    return BaseFile::write(buffer, size);
+  }
 };
 //------------------------------------------------------------------------------
 /**

Diff for: sources/Externals/opal/CMakeLists.txt

@@ -2,6 +2,11 @@ add_library(opal
 opal.h opal.cpp
 )
 
+# Disable the aggressive-loop-optimizations warning that can cause build errors with GCC14
+# this is causeed only by the code changes in opal.cpp lines 241-247 due to code for 4-Op
+# which would cause out of bounds access but doesnt because 4-Op are currently disabled
+target_compile_options(opal PRIVATE -Wno-aggressive-loop-optimizations)
+
 target_link_libraries(opal 
     PUBLIC application_utils
     PUBLIC hardware_flash

Diff for: sources/Foundation/T_Factory.h

@@ -9,7 +9,7 @@
 
 template <class Item> class T_Factory {
 protected:
-  virtual ~T_Factory<Item>(){};
+  virtual ~T_Factory(){};
 
 public:
   // Install the factory to use