Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WRP simple messages spec #51

Open
kristinapathak opened this issue Aug 7, 2020 · 0 comments · May be fixed by #53
Open

Update WRP simple messages spec #51

kristinapathak opened this issue Aug 7, 2020 · 0 comments · May be fixed by #53
Assignees
@joe94
Labels
device ID parsing documentation Improvements or additions to documentation enhancement New feature or request

Comments

@kristinapathak
Copy link
Contributor

https://github.com/xmidt-org/docs/blob/main/content/docs/wrp/simple-messages.md

The device ID isn't always the simple event's source anymore, so we should update the spec to specify the source to be the creator of the event and add a separate device_id field. The device_id field should also be added to the RequestResponse WRP, so that it can be specified in responses.
@kristinapathak kristinapathak mentioned this issue Aug 7, 2020
Open
@kristinapathak kristinapathak added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 7, 2020
@joe94 joe94 self-assigned this Aug 13, 2020
@joe94 joe94 linked a pull request Aug 14, 2020 that will close this issue
Update WRP Spec for deviceID #53
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joe94 joe94

Labels
device ID parsing documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update WRP Spec for deviceID xmidt-org/docs
2 participants
@joe94 @kristinapathak