-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support single quoting for attributes (on element basis) #74
Comments
I see your point. Can we simply change double quotes by single quoting? Will be there the chance of some developer require double quotes? In that case, should we support some how both options? I dislike configurations. But if we have to... @lcduarte What do you think about it? Can I simply change the character here https://github.com/xmlet/HtmlFlow/blob/master/src/main/java/htmlflow/Tags.java#L40 This is only used in Will we have complains of other guys in the future? |
To be honest, I think 99 % of users would hate if the default switched to single quote. But perhaps an extra optional param on the attributes flow builder would not disturb :p |
I think the only way to make everyone happy is to add an option on |
I am now planning to handle this issue for next release and I guess that is simpler and more effective to chose what kind of quotation to use (i.e. single or double) through properties. Then the end user programmer may choose single quotation by running Java with Simpler than requiring a new implementation of |
Looks like the right choice. We keep the default value as it was until this change and give the possibility of customizing it from now on. |
It would be nice being able to tell whether serializing the quotes as single like in:
<div data='{"a":"b"}'>
since those are legal in html
(To avoid hundreds of
"
)The text was updated successfully, but these errors were encountered: