Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: macos arm64 #105

Merged
merged 5 commits into from
Sep 6, 2024
Merged

BLD: macos arm64 #105

merged 5 commits into from
Sep 6, 2024

Conversation

luweizheng
Copy link
Contributor

github runner macos-13 auto arch is x86_64 this pr add arm64.
see: https://github.com/actions/runner-images/tree/main/images/macos

@XprobeBot XprobeBot added the build label Sep 6, 2024
@XprobeBot XprobeBot added this to the v0.3.4 milestone Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (d6465c9) to head (0bf9731).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   88.97%   85.10%   -3.88%     
==========================================
  Files          48       54       +6     
  Lines        4038     4559     +521     
  Branches      770      834      +64     
==========================================
+ Hits         3593     3880     +287     
- Misses        358      584     +226     
- Partials       87       95       +8     
Flag Coverage Δ
unittests 84.93% <ø> (-3.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit e4fad51 into xorbitsai:main Sep 6, 2024
13 of 14 checks passed
luweizheng added a commit to luweizheng/xoscar that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants