Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix deprecation warning caused by pkgutil.find_loader #109

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

hucorz
Copy link
Contributor

@hucorz hucorz commented Nov 4, 2024

What do these changes do?

fix deprecation warning by pkgutil.find_loader

DeprecationWarning: 'pkgutil.find_loader' is deprecated and slated for removal in Python 3.14; use importlib.util.find_spec() instead

Related issue number

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Nov 4, 2024
@XprobeBot XprobeBot added this to the epic milestone Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (d6465c9) to head (d7cd8d3).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   88.97%   84.79%   -4.19%     
==========================================
  Files          48       53       +5     
  Lines        4038     4558     +520     
  Branches      770      494     -276     
==========================================
+ Hits         3593     3865     +272     
- Misses        358      595     +237     
- Partials       87       98      +11     
Flag Coverage Δ
unittests 84.57% <ø> (-4.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit 2945d9a into xorbitsai:main Nov 4, 2024
13 of 14 checks passed
@luweizheng luweizheng changed the title ENH: fix deprecation warning by pkgutil.find_loader ENH: Fix deprecation warning caused by pkgutil.find_loader Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants