Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: stop using daemon=True for subpool #85

Merged
merged 10 commits into from
Mar 14, 2024

Conversation

qinxuye
Copy link
Contributor

@qinxuye qinxuye commented Mar 11, 2024

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Mar 11, 2024
@XprobeBot XprobeBot added this to the v1.0.0 milestone Mar 11, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.52%. Comparing base (2a041ae) to head (5ba4fe0).

❗ Current head 5ba4fe0 differs from pull request most recent head 1a58569. Consider uploading reports for the commit 1a58569 to get more accurate results

Files Patch % Lines
python/xoscar/backends/pool.py 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   89.12%   88.52%   -0.61%     
==========================================
  Files          48       47       -1     
  Lines        4010     3948      -62     
  Branches      764      757       -7     
==========================================
- Hits         3574     3495      -79     
- Misses        351      365      +14     
- Partials       85       88       +3     
Flag Coverage Δ
unittests 88.44% <97.29%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChengjieLi28 ChengjieLi28 merged commit 297f8b8 into xorbitsai:main Mar 14, 2024
22 of 24 checks passed
@qinxuye qinxuye deleted the enh/daemon branch March 14, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants