Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Fix CI, Remove pkg_resources #88

Merged
merged 10 commits into from
Jun 27, 2024
Merged

BLD: Fix CI, Remove pkg_resources #88

merged 10 commits into from
Jun 27, 2024

Conversation

luweizheng
Copy link
Contributor

Fix CI of macos arm64 chip.
Remove pkg_resources as setuptools is deprecated.

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.3.0 milestone Jun 24, 2024
@qinxuye
Copy link
Contributor

qinxuye commented Jun 25, 2024

Seems CI failed, could you look at it?

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (d6465c9) to head (941f3b9).

Current head 941f3b9 differs from pull request most recent head 2de5e9e

Please upload reports for the commit 2de5e9e to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   88.97%   87.61%   -1.37%     
==========================================
  Files          48       48              
  Lines        4038     4038              
  Branches      770      770              
==========================================
- Hits         3593     3538      -55     
- Misses        358      405      +47     
- Partials       87       95       +8     
Flag Coverage Δ
unittests 87.51% <ø> (-1.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/python.yaml Outdated Show resolved Hide resolved
python/pyproject.toml Show resolved Hide resolved
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 76f9ba9 into xorbitsai:main Jun 27, 2024
21 checks passed
@luweizheng luweizheng deleted the pypi branch June 27, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants