Skip to content

Commit 07c8b0c

Browse files
committed
More typing
1 parent 5fb6d26 commit 07c8b0c

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,9 @@
3737
from logging import getLogger
3838
from os import environ
3939
from time import time_ns
40-
from typing import Optional, Union, cast
40+
from typing import Optional, cast
4141

4242
from opentelemetry._logs.severity import SeverityNumber
43-
from opentelemetry.attributes import BoundedAttributes
4443
from opentelemetry.environment_variables import _OTEL_PYTHON_LOGGER_PROVIDER
4544
from opentelemetry.trace.span import TraceFlags
4645
from opentelemetry.util._once import Once
@@ -68,9 +67,7 @@ def __init__(
6867
severity_text: Optional[str] = None,
6968
severity_number: Optional[SeverityNumber] = None,
7069
body: AnyValue = None,
71-
attributes: Optional[
72-
Union[BoundedAttributes, ExtendedAttributes]
73-
] = None,
70+
attributes: Optional[ExtendedAttributes] = None,
7471
):
7572
self.timestamp = timestamp
7673
if observed_timestamp is None:

opentelemetry-sdk/src/opentelemetry/sdk/_events/__init__.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from opentelemetry._events import EventLoggerProvider as APIEventLoggerProvider
2222
from opentelemetry._logs import NoOpLogger, SeverityNumber, get_logger_provider
2323
from opentelemetry.sdk._logs import Logger, LoggerProvider, LogRecord
24-
from opentelemetry.util.types import Attributes
24+
from opentelemetry.util.types import ExtendedAttributes
2525

2626
_logger = logging.getLogger(__name__)
2727

@@ -33,7 +33,7 @@ def __init__(
3333
name: str,
3434
version: Optional[str] = None,
3535
schema_url: Optional[str] = None,
36-
attributes: Optional[Attributes] = None,
36+
attributes: Optional[ExtendedAttributes] = None,
3737
):
3838
super().__init__(
3939
name=name,
@@ -74,7 +74,7 @@ def get_event_logger(
7474
name: str,
7575
version: Optional[str] = None,
7676
schema_url: Optional[str] = None,
77-
attributes: Optional[Attributes] = None,
77+
attributes: Optional[ExtendedAttributes] = None,
7878
) -> EventLogger:
7979
if not name:
8080
_logger.warning("EventLogger created with invalid name: %s", name)

opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

+6-3
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from os import environ
2525
from threading import Lock
2626
from time import time_ns
27-
from typing import Any, Callable, Tuple, Union # noqa
27+
from typing import Any, Callable, Tuple, Union, cast # noqa
2828

2929
from opentelemetry._logs import Logger as APILogger
3030
from opentelemetry._logs import LoggerProvider as APILoggerProvider
@@ -251,8 +251,11 @@ def to_json(self, indent: int | None = 4) -> str:
251251

252252
@property
253253
def dropped_attributes(self) -> int:
254-
if self.attributes:
255-
return self.attributes.dropped
254+
attributes: BoundedAttributes = cast(
255+
BoundedAttributes, self.attributes
256+
)
257+
if attributes:
258+
return attributes.dropped
256259
return 0
257260

258261

0 commit comments

Comments
 (0)