Keep behavior the same for None values in list with allow_null=False

Author: aabmass

exporter/opentelemetry-exporter-otlp-proto-common/src/opentelemetry/exporter/otlp/proto/common/_internal/__init__.py

@@ -110,6 +110,10 @@ def _encode_key_value(
 def _encode_array(
     array: Sequence[Any], allow_null: bool = False
 ) -> Sequence[PB2AnyValue]:
+    if not allow_null:
+        # Let the exception get raised by _encode_value()
+        return [_encode_value(v, allow_null=allow_null) for v in array]
+
     return [
         _encode_value(v, allow_null=allow_null)
         if v is not None

exporter/opentelemetry-exporter-otlp-proto-common/tests/test_attribute_encoder.py

@@ -88,6 +88,24 @@ def test_encode_attributes_all_kinds(self):
             ],
         )
 
+    def test_encode_attributes_error_list_none(self):
+        with self.assertLogs(level=ERROR) as error:
+            result = _encode_attributes(
+                {"a": 1, "bad_key": ["test", None, "test"], "b": 2}
+            )
+
+        self.assertEqual(len(error.records), 1)
+        self.assertEqual(error.records[0].msg, "Failed to encode key %s: %s")
+        self.assertEqual(error.records[0].args[0], "bad_key")
+        self.assertIsInstance(error.records[0].args[1], Exception)
+        self.assertEqual(
+            result,
+            [
+                PB2KeyValue(key="a", value=PB2AnyValue(int_value=1)),
+                PB2KeyValue(key="b", value=PB2AnyValue(int_value=2)),
+            ],
+        )
+
     def test_encode_attributes_error_logs_key(self):
         with self.assertLogs(level=ERROR) as error:
             result = _encode_attributes({"a": 1, "bad_key": None, "b": 2})