Skip to content

Commit 8d74262

Browse files
committed
More typing
1 parent 9ee67b1 commit 8d74262

File tree

5 files changed

+17
-16
lines changed

5 files changed

+17
-16
lines changed

opentelemetry-api/src/opentelemetry/_events/__init__.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
from opentelemetry.trace.span import TraceFlags
2626
from opentelemetry.util._once import Once
2727
from opentelemetry.util._providers import _load_provider
28-
from opentelemetry.util.types import Attributes
28+
from opentelemetry.util.types import ExtendedAttributes
2929

3030
_logger = getLogger(__name__)
3131

@@ -40,7 +40,7 @@ def __init__(
4040
trace_flags: Optional["TraceFlags"] = None,
4141
body: Optional[Any] = None,
4242
severity_number: Optional[SeverityNumber] = None,
43-
attributes: Optional[Attributes] = None,
43+
attributes: Optional[ExtendedAttributes] = None,
4444
):
4545
attributes = attributes or {}
4646
event_attributes = {**attributes, "event.name": name}
@@ -62,7 +62,7 @@ def __init__(
6262
name: str,
6363
version: Optional[str] = None,
6464
schema_url: Optional[str] = None,
65-
attributes: Optional[Attributes] = None,
65+
attributes: Optional[ExtendedAttributes] = None,
6666
):
6767
self._name = name
6868
self._version = version
@@ -85,7 +85,7 @@ def __init__(
8585
name: str,
8686
version: Optional[str] = None,
8787
schema_url: Optional[str] = None,
88-
attributes: Optional[Attributes] = None,
88+
attributes: Optional[ExtendedAttributes] = None,
8989
):
9090
super().__init__(
9191
name=name,
@@ -122,7 +122,7 @@ def get_event_logger(
122122
name: str,
123123
version: Optional[str] = None,
124124
schema_url: Optional[str] = None,
125-
attributes: Optional[Attributes] = None,
125+
attributes: Optional[ExtendedAttributes] = None,
126126
) -> EventLogger:
127127
"""Returns an EventLoggerProvider for use."""
128128

@@ -133,7 +133,7 @@ def get_event_logger(
133133
name: str,
134134
version: Optional[str] = None,
135135
schema_url: Optional[str] = None,
136-
attributes: Optional[Attributes] = None,
136+
attributes: Optional[ExtendedAttributes] = None,
137137
) -> EventLogger:
138138
return NoOpEventLogger(
139139
name, version=version, schema_url=schema_url, attributes=attributes
@@ -146,7 +146,7 @@ def get_event_logger(
146146
name: str,
147147
version: Optional[str] = None,
148148
schema_url: Optional[str] = None,
149-
attributes: Optional[Attributes] = None,
149+
attributes: Optional[ExtendedAttributes] = None,
150150
) -> EventLogger:
151151
if _EVENT_LOGGER_PROVIDER:
152152
return _EVENT_LOGGER_PROVIDER.get_event_logger(
@@ -208,7 +208,7 @@ def get_event_logger(
208208
name: str,
209209
version: Optional[str] = None,
210210
schema_url: Optional[str] = None,
211-
attributes: Optional[Attributes] = None,
211+
attributes: Optional[ExtendedAttributes] = None,
212212
event_logger_provider: Optional[EventLoggerProvider] = None,
213213
) -> "EventLogger":
214214
if event_logger_provider is None:

opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
from typing import Optional, cast
4141

4242
from opentelemetry._logs.severity import SeverityNumber
43+
from opentelemetry.attributes import BoundedAttributes
4344
from opentelemetry.environment_variables import _OTEL_PYTHON_LOGGER_PROVIDER
4445
from opentelemetry.trace.span import TraceFlags
4546
from opentelemetry.util._once import Once
@@ -67,7 +68,7 @@ def __init__(
6768
severity_text: Optional[str] = None,
6869
severity_number: Optional[SeverityNumber] = None,
6970
body: AnyValue = None,
70-
attributes: Optional[ExtendedAttributes] = None,
71+
attributes: Optional[BoundedAttributes] = None,
7172
):
7273
self.timestamp = timestamp
7374
if observed_timestamp is None:
@@ -79,7 +80,7 @@ def __init__(
7980
self.severity_text = severity_text
8081
self.severity_number = severity_number
8182
self.body = body
82-
self.attributes = attributes
83+
self.attributes: Optional[BoundedAttributes] = attributes
8384

8485

8586
class Logger(ABC):

opentelemetry-api/src/opentelemetry/attributes/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ class BoundedAttributes(MutableMapping): # type: ignore
238238
def __init__(
239239
self,
240240
maxlen: Optional[int] = None,
241-
attributes: types.Attributes = None,
241+
attributes: Optional[types.ExtendedAttributes] = None,
242242
immutable: bool = True,
243243
max_value_len: Optional[int] = None,
244244
extended_attributes: bool = False,

opentelemetry-api/tests/events/test_proxy_event.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import opentelemetry._events as events
66
from opentelemetry.test.globals_test import EventsGlobalsTest
7-
from opentelemetry.util.types import Attributes
7+
from opentelemetry.util.types import ExtendedAttributes
88

99

1010
class TestProvider(events.NoOpEventLoggerProvider):
@@ -13,7 +13,7 @@ def get_event_logger(
1313
name: str,
1414
version: typing.Optional[str] = None,
1515
schema_url: typing.Optional[str] = None,
16-
attributes: typing.Optional[Attributes] = None,
16+
attributes: typing.Optional[ExtendedAttributes] = None,
1717
) -> events.EventLogger:
1818
return LoggerTest(name)
1919

opentelemetry-sdk/src/opentelemetry/sdk/util/instrumentation.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from deprecated import deprecated
1818

1919
from opentelemetry.attributes import BoundedAttributes
20-
from opentelemetry.util.types import Attributes
20+
from opentelemetry.util.types import ExtendedAttributes
2121

2222

2323
class InstrumentationInfo:
@@ -92,7 +92,7 @@ def __init__(
9292
name: str,
9393
version: Optional[str] = None,
9494
schema_url: Optional[str] = None,
95-
attributes: Optional[Attributes] = None,
95+
attributes: Optional[ExtendedAttributes] = None,
9696
) -> None:
9797
self._name = name
9898
self._version = version
@@ -150,7 +150,7 @@ def name(self) -> str:
150150
return self._name
151151

152152
@property
153-
def attributes(self) -> Attributes:
153+
def attributes(self) -> ExtendedAttributes:
154154
return self._attributes
155155

156156
def to_json(self, indent: Optional[int] = 4) -> str:

0 commit comments

Comments
 (0)