Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row major format #11

Open
egpbos opened this issue Oct 16, 2017 · 3 comments
Open

Row major format #11

egpbos opened this issue Oct 16, 2017 · 3 comments

Comments

@egpbos
Copy link
Member

egpbos commented Oct 16, 2017

Data arrays in FFTW must be in row major format (http://www.fftw.org/fftw3_doc/Row_002dmajor-Format.html). Currently, xtensor-fftw defines output arrays as row major, but it does not check for row major-ness on the input arrays. Should this be done or do we leave it to the user?

@egpbos
Copy link
Member Author

egpbos commented Nov 30, 2017

In the meantime, in some places, I have made the xarrays explicitly row-major. This should be done everywhere. Especially now that xtensor 0.14 has added full column-major support, we should make the basic functions explicitly row-major. Conversion from column- to row-major arrays should probably be xtensor functionality.

@egpbos
Copy link
Member Author

egpbos commented Nov 30, 2017

It should be added to the documentation as well though.

egpbos added a commit that referenced this issue Nov 30, 2017
About row-major order (#11) and destructive inverse real FFTs (#12).
@egpbos
Copy link
Member Author

egpbos commented Nov 30, 2017

Added to documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant