Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CMakeFiles #60

Open
egpbos opened this issue Oct 26, 2021 · 0 comments
Open

Clean up CMakeFiles #60

egpbos opened this issue Oct 26, 2021 · 0 comments

Comments

@egpbos
Copy link
Member

egpbos commented Oct 26, 2021

The CMakeFiles have become a bit messy and seem overcomplicated. I think a modern CMake makeover would help a lot. Things like FFTW_LINK_FLAGS, for instance, should not be used as such, since linker flags and linking targets are two things that are defined separately, so combining them in one variable is not CMake-ish. Other things like set for custom variables are also code smells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant