You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This feature is important to have in this repository; a contrib plugin wouldn't do
Describe the user story
I'm using a private Artifactory repository. In the setup guide, they provide the command: npm config set registry https://repository.company.com/artifactory/api/npm/v-npm/. However, when requesting package information, the response contains something like "tarball": "https://repository.company.com:443/artifactory/api/npm/v-npm/package-name/-/package-name-version.tgz". The current implementation of isConventionalTarballUrl treats a difference in port as a sign of an unconventional tarball. Thus the __archiveUrl is added to every package in yarn.lock when it's unnecessary.
Describe the solution you'd like
The solution would be to ignore the default ports, e.g., 80 for HTTP and 443 for HTTPS, if they are present. This would prevent the issue without affecting unconventional URLs.
Describe the drawbacks of your solution
Using default and custom repositories won't be affected. This change will only provide convenience for different URL variants, such as https://repository.com and https://repostiory.com:443, which basically mean the same. The unnecessary __archiveUrl won't appear.
Describe alternatives you've considered
Currently, the only way to prevent this is to determine if the JSON returned from the repository contains a port. Depending on this, configure the npmRegistryServer accordingly to prevent the __archiveUrl from appearing.
The text was updated successfully, but these errors were encountered:
Uh oh!
There was an error while loading. Please reload this page.
Describe the user story
I'm using a private Artifactory repository. In the setup guide, they provide the command:
npm config set registry https://repository.company.com/artifactory/api/npm/v-npm/
. However, when requesting package information, the response contains something like"tarball": "https://repository.company.com:443/artifactory/api/npm/v-npm/package-name/-/package-name-version.tgz"
. The current implementation of isConventionalTarballUrl treats a difference in port as a sign of an unconventional tarball. Thus the__archiveUrl
is added to every package in yarn.lock when it's unnecessary.Describe the solution you'd like
The solution would be to ignore the default ports, e.g., 80 for HTTP and 443 for HTTPS, if they are present. This would prevent the issue without affecting unconventional URLs.
Describe the drawbacks of your solution
Using default and custom repositories won't be affected. This change will only provide convenience for different URL variants, such as
https://repository.com
andhttps://repostiory.com:443
, which basically mean the same. The unnecessary__archiveUrl
won't appear.Describe alternatives you've considered
Currently, the only way to prevent this is to determine if the JSON returned from the repository contains a port. Depending on this, configure the
npmRegistryServer
accordingly to prevent the__archiveUrl
from appearing.The text was updated successfully, but these errors were encountered: