Feature implementation from commits 41b8d83..f675763 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when using a class-scoped type alias defined using a `type` statement or `TypeAliasType` constructor. This addresses microsoft#10330. (microsoft#10332)
… refers to itself. This addresses microsoft#10287. (microsoft#10334)
…circumstances where bidirectional type inference is attempted in the assignment of an attribute. This addresses microsoft#10345.
…. These result in a runtime exception. This addresses microsoft#10351. (microsoft#10353)
…ction with an unpacked TypedDict with `extra_items` when additional keyword args are passed. This addresses microsoft#10352. (microsoft#10357)
Co-authored-by: Bill Schnurr <[email protected]> Co-authored-by: HeeJae Chang <[email protected]> Co-authored-by: Erik De Bonte <[email protected]> Co-authored-by: Rich Chiodo <[email protected]> Co-authored-by: Stella Huang <[email protected]> Co-authored-by: Kacie Kang <[email protected]>
…attern (where S is a string literal and D is a TypedDict). If the TypedDict is not closed, the absence of the key within the TypedDict definition cannot eliminate the type during narrowing. This addresses microsoft#10376. (microsoft#10378)
…TypedDict that is defined with `extra_items=Never`. This addresses microsoft#10377. (microsoft#10379)
…where a descriptor object is stored in a `__slots__` variable. This addresses microsoft#10370. (microsoft#10382)
…y access method uses a method-local type variable to annotate the `self` parameter. This addresses microsoft#10367. (microsoft#10387)
…stances where the second argument for a `super` call is a union. This addresses microsoft#10388. (microsoft#10389)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes from a range of commits from the original repository.
Commit Range:
41b8d83..f675763Files Changed: 53 (30 programming files)
Programming Ratio: 56.6%
Commits included:
supercall is a union. This addresses Unexpected error 'Second argument to "super" call must be object or class that derives from XX' microsoft/pyright#10388. (Fixed bug that results in a false positive error under certain circum… microsoft/pyright#10389)selfparameter. This addresses Incorrect variance inference due to @property with a custom self: annotation microsoft/pyright#10367. (Fixed bug that results in incorrect variance inference when a propert… microsoft/pyright#10387)__slots__members to correctly model the case where a descriptor object is stored in a__slots__variable. This addresses Assigning descriptor instance to a class defining__slots__causes undesired type narrowing microsoft/pyright#10370. (Improved handling of__slots__members to correctly model the case … microsoft/pyright#10382)extra_items=Never. This addresses False negative when accessing TypedDict withextra_items=Nevermicrosoft/pyright#10377. (Fixed a bug that leads to a false negative when accessing a key on a … microsoft/pyright#10379)S in Dtype guard pattern (where S is a string literal and D is a TypedDict). If the TypedDict is not closed, the absence of the key within the TypedDict definition cannot eliminate the type during narrowing. This addresses Incorrect type narrowing for TypedDicts using theS in Dtype guard pattern microsoft/pyright#10376. (Fixed a bug in the type narrowing logic for theS in Dtype guard p… microsoft/pyright#10378)azure-pipelines-release.yml(Temporarily disable npm publishing inazure-pipelines-release.ymlmicrosoft/pyright#10360)extra_itemswhen additional keyword args are passed. This addresses Pep 728 support for TypedDict with Unpack does not allow extra items microsoft/pyright#10352. (Fixed a bug that results in a false positive error when calling a fun… microsoft/pyright#10357)... and 5 more commits