Feature implementation from commits e77fca4..f2adab3 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s an internal simplification. No functional change.
…lass-scoped type alias defined as a callable. This addresses microsoft#10282. (microsoft#10308)
…cases where a ternary expression is assigned to an annotated instance or class variable and the ternary condition narrows the type of `self` or `cls`. This addresses microsoft#10318. (microsoft#10321)
… check to enforce imports from submodules whose names begin with an underscore. This change was disruptive to users of the popular `pandas` library because it exports a submodule named `_typing`. This was originally intended to be experimental or private, but it was never fully addressed. The pandas maintainers will work to fix this issue (pandas-dev/pandas#55231) over the next year. I'm going to back out this change to pyright in the meantime. (microsoft#10322)
… in Python 3.14 if a `return`, `break` or `continue` is used to exit a `finally` clause. This addresses microsoft#10319. (microsoft#10323)
… when using a class-scoped type alias defined using a `type` statement or `TypeAliasType` constructor. This addresses microsoft#10330. (microsoft#10332)
… refers to itself. This addresses microsoft#10287. (microsoft#10334)
…circumstances where bidirectional type inference is attempted in the assignment of an attribute. This addresses microsoft#10345.
…. These result in a runtime exception. This addresses microsoft#10351. (microsoft#10353)
…ction with an unpacked TypedDict with `extra_items` when additional keyword args are passed. This addresses microsoft#10352. (microsoft#10357)
Co-authored-by: Bill Schnurr <[email protected]> Co-authored-by: HeeJae Chang <[email protected]> Co-authored-by: Erik De Bonte <[email protected]> Co-authored-by: Rich Chiodo <[email protected]> Co-authored-by: Stella Huang <[email protected]> Co-authored-by: Kacie Kang <[email protected]>
![codeowlai[bot]](https://avatars.githubusercontent.com/in/1259765?s=60&v=4){kind=small}
| '-=': OperatorType.SubtractEqual, | ||
| and: OperatorType.And, | ||
| or: OperatorType.Or, | ||
| 'not ': OperatorType.Not, |
There was a problem hiding this comment.
🐛 Correctness Issue
Trailing space in operator key.
The 'not ' operator key has a trailing space which will cause lookup failures when code tries to map the string 'not' to its operator type.
Current Code (Diff):
- 'not ': OperatorType.Not,
+ not: OperatorType.Not,📝 Committable suggestion
‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀
Suggested change
| 'not ': OperatorType.Not, | |
| not: OperatorType.Not, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes from a range of commits from the original repository.
Commit Range:
e77fca4..f2adab3Files Changed: 69 (46 programming files)
Programming Ratio: 66.7%
Commits included:
azure-pipelines-release.yml(Temporarily disable npm publishing inazure-pipelines-release.ymlmicrosoft/pyright#10360)extra_itemswhen additional keyword args are passed. This addresses Pep 728 support for TypedDict with Unpack does not allow extra items microsoft/pyright#10352. (Fixed a bug that results in a false positive error when calling a fun… microsoft/pyright#10357)Callabletype microsoft/pyright#10287. (Fixed a bug that leads to a hang when a generic type alias definition… microsoft/pyright#10334)typestatement orTypeAliasTypeconstructor. This addresses Nested type aliases in classes specialize prematurely microsoft/pyright#10330. (Fixed bug that results in a spurious "type already specialized" error… microsoft/pyright#10332)... and 5 more commits