forked from microsoft/pyright
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature implementation from commits 942e889..ccb22d0 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yashuatla
wants to merge
15
commits into
feature-base-5
Choose a base branch
from
feature-head-5
base: feature-base-5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and fdel methods. (microsoft#10206)
…at uses `Self` in a contravariant position. This addresses https://discuss.python.org/t/unsoundness-of-contravariant-self-type/86338. (microsoft#10209)
…stances involving a type variable with an upper bound of `type[T]` that is assigned to another type variable. This addresses microsoft#10207. (microsoft#10210)
…ol matching introduced in recent change. (microsoft#10215)
…alue whose type is a generic class parameterized by `Unknown` is assigned to a variable with a declared type. This addresses microsoft#10214. (microsoft#10217)
…of a TypeVarTuple includes multiple unpacked tuples of unknown length. This addresses microsoft#10219. (microsoft#10220)
…ed in Python 2.7 but are syntax errors in Python 3.x. This addresses microsoft#10222. (microsoft#10223)
…s from `type[Any]` is assigned to any other type. This addresses microsoft#10185. (microsoft#10224)
…ces when inferring the return type of a recursive function that has a decorator or is `async`. This addresses microsoft#10242. (microsoft#10244)
…ntains a call expression that invokes a `NoReturn` call and the argument list contains errors. This addresses microsoft#10260. (microsoft#10264)
…ion to flag the `Literal` special form, which leads to a runtime error when used in the second argument. This addresses microsoft#10258. (microsoft#10265)
…parison` check when one operand's type is a callable and the other is not. This addresses microsoft#10253. (microsoft#10267)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes from a range of commits from the original repository.
Commit Range:
942e889..ccb22d0
Files Changed: 474 (472 programming files)
Programming Ratio: 99.6%
Commits included:
reportUnnecessaryComparison
check when one operand's type is a callable and the other is not. This addresses Typesobject
andCallable
are reported to not have any overlap. microsoft/pyright#10253. (Fixed bug that leads to a false positive in the `reportUnnecessaryCom… microsoft/pyright#10267)isinstance
andissubclass
argument validation to flag theLiteral
special form, which leads to a runtime error when used in the second argument. This addresses Pyright does not detect Literals cannot be used with class and instance checks microsoft/pyright#10258. (Extended the check forisinstance
andissubclass
argument validat… microsoft/pyright#10265)NoReturn
call and the argument list contains errors. This addresses if no argumentos._exit()
comes afterreturn
, pyright doesn't notice us microsoft/pyright#10260. (Fixed bug that results in a false negative when a return statement co… microsoft/pyright#10264)async
. This addresses Type checking is wrong with recursive asynchrone functions microsoft/pyright#10242. (Fixed bug that results in an incorrect error under certain circumstan… microsoft/pyright#10244)type[Any]
is assigned to any other type. This addresses Regression numpy dtype incorrectly inferred when base class is unknown microsoft/pyright#10185. (Fixed a bug that results in a false negative when a class that derive… microsoft/pyright#10224)ru
andur
string prefixes. These were supported in Python 2.7 but are syntax errors in Python 3.x. This addresses Missing syntax error for "ru" (raw Unicode) string prefix microsoft/pyright#10222. (Removed support forru
andur
string prefixes. These were support… microsoft/pyright#10223)reportUnknownVariableType
check to include cases where a value whose type is a generic class parameterized byUnknown
is assigned to a variable with a declared type. This addresses Disallowing castingUnknown
in variable definition in strict mode microsoft/pyright#10214. (ExtendedreportUnknownVariableType
check to include cases where a v… microsoft/pyright#10217)... and 5 more commits