Skip to content

can it support highlighting content inside of a child component? #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
junyu-w opened this issue Feb 7, 2018 · 3 comments
Open

Comments

@junyu-w
Copy link

junyu-w commented Feb 7, 2018

It would be neat if I could pass another component to the text (or maybe child) field and be able to highlight text inside of that component

@ydeshayes
Copy link
Owner

Hello,

What is the use case for that? because you can use multiple instances in one screen with the current one. Maybe you are thinking about the component being more convenient to use?

@junyu-w
Copy link
Author

junyu-w commented Feb 19, 2018

Hi, basically the use case that I was thinking about is if I have a nested components with texts scattered around, and I would like to make them all highlightable once for all, it would be more tedious for me to add the Highlightable component everywhere and keep track of it than just pass the root component and get all the texts highlightable at once

@desktp
Copy link

desktp commented May 17, 2018

I also have a use case of using it with a contentEditable div or an input, where having the Highlightable component as a parent would help immensely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants