Memory leak in restore script

[dusterio]

I'm running restore script on a modest 18Mb file and it throws an exception after a while:

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
1: node::Abort() [/usr/local/bin/node]
2: node::FatalException(v8::Isolate*, v8::Localv8::Value, v8::Localv8::Message) [/usr/local/bin/node]

I assume it's a memory leak?

[0crat]

@yegor256 please, pay attention to this issue

[dusterio]

There seems to be another issue with the restore script, at least on OS X - it pretty much doesn't work at all :) The async behaviour is broken - the script postpones Dynamo's PUTs till the read loop is over. If the loop is long enough (100k lines in my case), the script won't do anything at all - it will just crash somewhere in the middle.

Even though it looks like objects should be inserted asynchronously, it's not happening for some reason. Very easy to test - add a console.log() to Dynamo's callback, you will see that it's only reached before the whole script finishes.

Could be something about piping input/output in OS X, or Readline or whatever.

[yegor256]

@dusterio oops... Can you contribute with a pull request or you don't know how to fix that?

[dusterio]

@yegor256 I'm playing around with it at the moment, I'll propose a PR once I'm done :)

[yegor256]

@dusterio thanks!

[dusterio]

@yegor256 I see that you are not using ES6 features like arrow functions - is that on purpose, to support old Node or something? Do you want to avoid them in PRs too?

[yegor256]

@dusterio no purpose here. Feel free to refactor the code the way you see it right, using all possible new features :)

[yegor256]

@dusterio any ideas here?