Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Flag for autoclose sidebar when applying all changes (pressing 'A') #743

Open
icristianhernandez opened this issue Oct 21, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@icristianhernandez
Copy link
Contributor

icristianhernandez commented Oct 21, 2024

Feature request

Flag to close the sidebar view after pressing 'A' to apply all changes. The same as title.

Motivation

In general I don't like splits in any editor. So, I need to manually close the sidebar everytime I'm applying changes to have the view with one buffers that I like (for the same reasons I like if the sidebar can be floating, but I see other issue open for that).

Other

No response

@icristianhernandez icristianhernandez added the enhancement New feature or request label Oct 21, 2024
@b0o
Copy link
Collaborator

b0o commented Oct 21, 2024

I think this would be a nice feature behind a configuration flag. Should this only take effect when applying all via A, but not when applying a single diff via a?

@icristianhernandez icristianhernandez changed the title feature: Autoclose sidebar when applying all changes (pressing 'A') feature: Flag for autoclose sidebar when applying all changes (pressing 'A') Oct 21, 2024
@icristianhernandez
Copy link
Contributor Author

I think this would be a nice feature behind a configuration flag. Should this only take effect when applying all via A, but not when applying a single diff via a?

Actually, I was thinking of a flag for that feature. I've been getting only 2-3 hours of sleep for the past few days, and my brain is foggy. I edited the issue to express it better.

Regarding the single diff via a, I'm not sure what the best approach is. Maybe we could add two new keymaps to the sidebar mappings: "apply_all_and_hide" and "apply_cursor_and_hide".

@aarnphm
Copy link
Collaborator

aarnphm commented Oct 22, 2024

I think gated behind A makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants