From beefa9d53e37c602440be2b446cc085df6e4a118 Mon Sep 17 00:00:00 2001 From: Jisse Reitsma Date: Tue, 27 Jun 2023 13:24:24 +0200 Subject: [PATCH] Fix issue with uninitialized `eventData` caused by 3.4.4 --- CHANGELOG.md | 4 ++++ composer.json | 2 +- view/frontend/web/js/mixins/step-navigator-mixin.js | 4 ++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index df139391..1ef23163 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [3.4.5] - 27 June 2023 +### Fixed +- Fix issue with uninitialized `eventData` caused by 3.4.4 + ## [3.4.4] - 26 June 2023 ### Fixed - Fixed stepNavigator issue in non-default checkout diff --git a/composer.json b/composer.json index 157f031d..32ab952c 100644 --- a/composer.json +++ b/composer.json @@ -1,6 +1,6 @@ { "name": "yireo/magento2-googletagmanager2", - "version": "3.4.4", + "version": "3.4.5", "license": "OSL-3.0", "type": "magento2-module", "homepage": "https://www.yireo.com/software/magento-extensions/googletagmanager2", diff --git a/view/frontend/web/js/mixins/step-navigator-mixin.js b/view/frontend/web/js/mixins/step-navigator-mixin.js index 9072a239..b8eb0b28 100644 --- a/view/frontend/web/js/mixins/step-navigator-mixin.js +++ b/view/frontend/web/js/mixins/step-navigator-mixin.js @@ -12,6 +12,8 @@ define([ stepNavigator.steps.subscribe(function (steps) { const firstStep = steps[0]; + const eventData = window.YIREO_GOOGLETAGMANAGER2_BEGIN_CHECKOUT; + if (firstStep === undefined || firstStep == null || firstStep.length <= 0) { logger('Error: No steps detected. Triggering event anyway :o') pusher(eventData, 'push (page event "begin_checkout") [step-navigator-mixin.js]'); @@ -22,8 +24,6 @@ define([ return; } - const eventData = window.YIREO_GOOGLETAGMANAGER2_BEGIN_CHECKOUT; - if (eventData === null || eventData === undefined) { logger('skipped "begin_checkout" event because data is empty') return;