diff --git a/CHANGELOG.md b/CHANGELOG.md index f8555f8d..df139391 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [3.4.4] - 26 June 2023 +### Fixed +- Fixed stepNavigator issue in non-default checkout + ## [3.4.3] - 22 June 2023 ### Fixed - Mixins are still active even when enabled = false @@ -13,7 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [3.4.2] - 21 June 2023 ### Fixed - Prevent add-to-cart to trigger view-cart, when view-cart is on cart-page only -- Missing Quantity Parameter in add_to_cart Event +- Missing Quantity Parameter in `add_to_cart` Event ## [3.4.1] - 20 June 2023 ### Fixed diff --git a/composer.json b/composer.json index 8e3c1269..157f031d 100644 --- a/composer.json +++ b/composer.json @@ -1,6 +1,6 @@ { "name": "yireo/magento2-googletagmanager2", - "version": "3.4.3", + "version": "3.4.4", "license": "OSL-3.0", "type": "magento2-module", "homepage": "https://www.yireo.com/software/magento-extensions/googletagmanager2", diff --git a/view/frontend/web/js/mixins/step-navigator-mixin.js b/view/frontend/web/js/mixins/step-navigator-mixin.js index e74469d0..9072a239 100644 --- a/view/frontend/web/js/mixins/step-navigator-mixin.js +++ b/view/frontend/web/js/mixins/step-navigator-mixin.js @@ -11,16 +11,25 @@ define([ } stepNavigator.steps.subscribe(function (steps) { - if (steps[0].isVisible()) { - const eventData = window.YIREO_GOOGLETAGMANAGER2_BEGIN_CHECKOUT; + const firstStep = steps[0]; + if (firstStep === undefined || firstStep == null || firstStep.length <= 0) { + logger('Error: No steps detected. Triggering event anyway :o') + pusher(eventData, 'push (page event "begin_checkout") [step-navigator-mixin.js]'); + return; + } - if (eventData === null || eventData === undefined) { - logger('skipped "begin_checkout" event because data is empty') - return; - } + if (!firstStep.isVisible()) { + return; + } + + const eventData = window.YIREO_GOOGLETAGMANAGER2_BEGIN_CHECKOUT; - pusher(eventData, 'push (page event "begin_checkout") [step-navigator-mixin.js]'); + if (eventData === null || eventData === undefined) { + logger('skipped "begin_checkout" event because data is empty') + return; } + + pusher(eventData, 'push (page event "begin_checkout") [step-navigator-mixin.js]'); }); return stepNavigator;