Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Daxko module looks outdated #2369

Open
ddrozdik opened this issue Jan 11, 2021 · 7 comments · May be fixed by #2559
Open

Daxko module looks outdated #2369

ddrozdik opened this issue Jan 11, 2021 · 7 comments · May be fixed by #2559
Labels
dependencies Issues with dependencies Level: Middle Needs skilled developer to work on Needs approval Needs approval by YUSA or/and OpenY core team Severity: Minor Backlog Type: Task Maintenance, subtasks

Comments

@ddrozdik
Copy link
Contributor

It seems daxko module(the first version) is outdated already and can be deleted from the distribution. Could you check it?

@sarah-halby
Copy link
Collaborator

@ddrozdik is this in regards to Activity Finder or just in general? I want to make sure @podarok has the information he needs to move forward.

@ddrozdik
Copy link
Contributor Author

@sarah-halby in general, the module https://github.com/ymcatwincities/openy/tree/9.x-2.x/modules/custom/daxko was created 4 years ago. There are some dependencies to this module however, they are not relevant anymore.
On the other hand, there is a module https://github.com/ymcatwincities/openy/tree/9.x-2.x/modules/custom/openy_daxko2 that works with API v2 and seems the most used across all Ys.

I don't have much information to decide that's why we need to investigate if we can safely deprecate it and remove it in future versions.

@podarok
Copy link
Contributor

podarok commented Jan 12, 2021

I agree that if we are not using it anymore - it is a good candidate for deprecation and decoupling to a dedicated repository just in case if needed
I guess due to this is a change, functional change, we should be careful and we need to notify the community this is coming in the same way as we do for the media_*, openy_autocomplete_path, and some other modules, described in the upcoming February release as deprecated.
@sarah-halby

@podarok podarok added dependencies Issues with dependencies Level: Middle Needs skilled developer to work on Needs approval Needs approval by YUSA or/and OpenY core team Severity: Minor Backlog Type: Task Maintenance, subtasks labels Jan 12, 2021
@sarah-halby
Copy link
Collaborator

@ddrozdik can you confirm that your clients are not using this module? I will connect with OneEach, JW Tech, and ImageX. The plan is that the code is not removed and not decoupled, however, it will not be tested in new releases.

@sarah-halby sarah-halby added this to the Q2 release 2021 milestone Jan 12, 2021
@ddrozdik
Copy link
Contributor Author

@sarah-halby yes, I confirm we do not use it across all our clients.

podarok added a commit that referenced this issue Sep 24, 2021
@podarok podarok linked a pull request Sep 24, 2021 that will close this issue
9 tasks
@podarok
Copy link
Contributor

podarok commented Sep 24, 2021

 The service "openy_programs_search.data_storage" has a dependency on a non-  
  existent service "daxko.client".   

@sarah-halby
Copy link
Collaborator

@podarok should this ticket be closed after you confirm with IMX and YUSA that they are not using this module?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issues with dependencies Level: Middle Needs skilled developer to work on Needs approval Needs approval by YUSA or/and OpenY core team Severity: Minor Backlog Type: Task Maintenance, subtasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants