expiringdict for ring.dict(expire)

[youknowone]

https://pypi.org/project/expiringdict/

Instead of ExpirableDictStorage implementation, replacing dict to expringdict looks simpler and reasonable

[seeeturtle]

@youknowone, i tried to use ExpiringDict but it seems PyPI is not following up the master branch.
the last release of PyPI is Sep, 2017.

i guess it's not a good idea to use expiringdict.

[youknowone]

Hello, thanks for trying to contribute about this issue.

By checking expiringdict commits in https://github.com/mailgun/expiringdict/commits/master, it seems there was not much changes since 2017. The changes also not looks like critical issues about the project. If there is not known issues about the project, I think this can be proof of stability and concreteness of the project. How do you think about it?

[seeeturtle]

I think the problem is that there is no option for permanent cache. If we want to implement that feature, I think it’s not really different from current implementation of ring. 나의 iPad에서 보냄 2019. 7. 20. 오전 12:44, Jeong YunWon <[email protected]> 작성:

…

Hello, thanks for trying to contribute about this issue. By checking expiringdict commits in https://github.com/mailgun/expiringdict/commits/master, it seems there was not much changes since 2017. The changes also not looks like critical issues about the project. If there is not known issues about the project, I think this can be proof of stability and concreteness of the project. How do you think about it? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[youknowone]

I think normal dict is good enough for permanent cache. For now, we use different backend for permanent cache and expirable cache. we can keep the permanent one as bow and just replace expirable one to expiringdict. Please let me know if there is any concern I missed.

[seeeturtle]

Ok, I got it. Thanks for answering my questions.