Review remaining element-level data completeness alerts for correctness

[emmajclegg]

Following implementation of #1553, can we review data-completeness logic for remaining elements where I suspect it is incorrect.

Requirement:

• Elements should be marked "completed" on the Activity Data or Organisation Data pages if all their mandatory sub-elements have been populated.
• If an element has no mandatory sub-elements (e.g. location), then it should be marked completed if any of the optional sub-elements have been completed.

Activity elements affected:

• recipient-country and recipient-region covered in #1595
• contact-info
• planned-disbursement

Organisation elements affected:

• total-budget
• recipient-region-budget
• recipient-country-budget
• total-expenditure
• document-link

Please ask if any of the mandatory vs. optional logic is not clear for these elements.

This test activity should have all elements completed with their mandatory sub-elements - i.e. it shows which data completeness alerts are too strict currently

[PG-Momik]

@emmajclegg
Following our discussion, I've reviewed the module for completeness calculation. For us to implement new completion rules that reflect the recent changes of #1553 , the actual changes in the back-end would be 1 liner. However we'd need to update some of the existing unit tests and also perform some degree of manual testing.

cc: @BibhaT

[emmajclegg]

For us to implement new completion rules that reflect the recent changes of #1553 , the actual changes in the back-end would be 1 liner. However we'd need to update some of the existing unit tests and also perform some degree of manual testing.

Ok thanks @PG-Momik. This sounds sensible to do in that case.

In terms of new work to pick up when you can this month, I've ordered the "proposed user story/task" Github list in rough order of priority, so this issue doesn't need to be done straight away. #1596, for example, is at the top as it's causing users to publish data with errors, so that issue would be higher impact to work on.