Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations not shipped with project #278

Open
VLN37 opened this issue Jun 4, 2023 · 1 comment
Open

Migrations not shipped with project #278

VLN37 opened this issue Jun 4, 2023 · 1 comment

Comments

@VLN37
Copy link

VLN37 commented Jun 4, 2023

Hello guys.

I understand that it may be a design choice to delegate makemigrations and migrate to the client. It makes sense when django is capable of handling those changes alone. Several other times, however, migrations have to be written manually in order to be backwards compatible and whatknot.

In that vein, our project ensures that those migrations are not missing in our CI process, blocking pull requests that make database without syncing the migrations.

Due to that, we had to disable those checks when incorporating django-cities-light. Thanks for the work btw, it is a lot better than the solution we used previously.

Therefore i suggest that it may be considered, for compatibility with good industry practices, to ship migrations in the relevant {app_name}/fixtures folders.

Since this is a design decision, i chose to open an issue for discussion rather than issuing a new pull request.

Thanks for your time, John.

@marianoeramirez
Copy link
Collaborator

marianoeramirez commented Sep 6, 2023

HI @VLN37 the project has the migrations. Could you explain a bit more about what migrations are not backward compatible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants