dtype is unused input parameter in get_conversion_factor

[Cpp87]

I found that _get_conversion_factor takes "dtype" as 3rd input parameter. This parameter is unused, so I suggest removing it.
The private function is called because unit.get_conversion_factor, which can also drop "dtype", delegates to it.

function signature:
def get_conversion_factor(self, other_units, dtype=None):
return _get_conversion_factor(self, other_units, dtype)

code state: main branch from 5th May 2025, hash: 2fd015d

[neutrinoceros]

Thanks for reporting this. The dtype argument is documented, and part of a public API (Unit.get_conversion_factor) and as such, it shouldn't be just removed. Instead, it should be used as originally intended, so I would flag this as a bug. Would you be interested in opening a PR ?

[Cpp87]

Thanks for the quick response. I came across this because I wanted to make a suggestion for #577.
But I didn't want to do two changes at a time. I am willing to help if the "request for change" in 577 is feasible.