Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chombo datasets unpack inconsistently #73

Open
munkm opened this issue Nov 22, 2019 · 2 comments
Open

Chombo datasets unpack inconsistently #73

munkm opened this issue Nov 22, 2019 · 2 comments

Comments

@munkm
Copy link
Member

munkm commented Nov 22, 2019

I've been going through and downloading the frontend data from our webpage. When downloading the five datasets for the chombo frontend I get inconsistent ways that they're unpacked. Three of them unpack into folders similarly named to their .tar.gz folder. Those are:

  • IsothermalSphere.tar.gz --> IsothermalSphere/
  • KelvinHelmholtz.tar.gz --> KelvinHemholtz/
    -ZeldovichPancake.tar.gz --> ZeldovichPancake/

Two of the zipped files unzip the data file into the current directory. Those are:
TurbBoxLowRes.tar.gz --> data.0005.3d.hdf5
GaussianCloud.tar.gz --> data.0077.3d.hdf5

I think we probably should have consistent unzipping for each frontend? Looking at the frontend it also seems that the latter two files are expected to be located in "GaussianCloud/data.0077.3d.hdf5" and "TurbBoxLowRes/data.0005.3d.hdf5", respectively.

@ngoldbaum
Copy link
Member

ngoldbaum commented Nov 22, 2019

This was probably just an oversight when those datasets were originally added. I've been trying to make sure the datasets all unpack into folders with useful names rather than as files but there are some that don't do that because I forgot to check or because someone else uploaded the file who wasn't aware that was a thing we were trying to do.

I'd personally say it's fine to just fix this in-place on the webserver -- I'd be surprised if anyone was depending on the name of the directory that these files get unpacked into.

@munkm
Copy link
Member Author

munkm commented Nov 22, 2019

Yeah, I don't think it's a huge deal. I just wanted to make sure the issue was documented somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants