This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
removes fetch override #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
Could you explain the conflict in a little more detail? I've been using my fork since I created it and haven't experienced any issues. |
|
As I remember, the I will checkout your code to test it locally. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8
There's a bug with this extension that breaks live logs from github actions due to the fetch api being manipulated to add a
__account__query parameter to every request. This causes a 400 when trying to query the github pipeline API.This "fix" is to just remove all of the code surrounding the fetch override and any other references to
__account__. As far as I can tell, everything about the extension still works fine as well as live logs from github actions.I'm happy to have another crack at this if there is a reason for the code I've removed to still exist.