Commit eff21a0
committed
[#25400] YSQL: remove some outdated YB_TODOs
Summary:
- Remove outdated YB_TODO in genam.c:
- Commit b263910 moves ybctid out of
ItemPointer. RelationGetIndexScan tries to clear PG ctid and
ybctid. ybctid is moved to xs_itup (IndexTuple) and xs_hitup
(HeapTuple), but both are already set to NULL, so there is no extra
clearing necessary.
- Remove outdated YB_TODO in indexcmds.c:
- safe_index is more suited towards PG's CREATE INDEX CONCURRENTLY.
It can make some sense for YB's, but given YB doesn't support
transactional DDL and transaction blocks currently adopt a fixed
catalog version for the entire transaction, YB is far from being
able to use safe_index at the moment. So ignore it for the YB code
path.
- pgstat_* is already properly merged. Most of the code was merged in
by YB ced7c32. It explicitly
avoids the PG phases PROGRESS_CREATEIDX_PHASE_WAIT_* and introduces
YB phases. PG 92942642788c9d73e4c090ee0a77603f7afbc1d7 is related
to the PG phase, so it is irrelevant for YB.
Jira: DB-14631
Test Plan:
Close: #25400
Jenkins: skip
Reviewers: fizaa
Reviewed By: fizaa
Subscribers: yql
Differential Revision: https://phorge.dev.yugabyte.com/D407851 parent cb55547 commit eff21a0
File tree
2 files changed
+0
-7
lines changed- src/postgres/src/backend
- access/index
- commands
2 files changed
+0
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | 136 | | |
141 | 137 | | |
142 | 138 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
533 | 533 | | |
534 | 534 | | |
535 | 535 | | |
536 | | - | |
537 | | - | |
538 | | - | |
539 | 536 | | |
540 | 537 | | |
541 | 538 | | |
| |||
0 commit comments