Merge pull request #334 from yukinarit/do-not-render-init-false

Do not render field with init=False

Author: yukinarit

serde/core.py

@@ -436,7 +436,7 @@ class Foo:
     name: Optional[str]
     default: Any = field(default_factory=dataclasses._MISSING_TYPE)
     default_factory: Any = field(default_factory=dataclasses._MISSING_TYPE)
-    init: Any = field(default_factory=dataclasses._MISSING_TYPE)
+    init: bool = field(default_factory=dataclasses._MISSING_TYPE)
     repr: Any = field(default_factory=dataclasses._MISSING_TYPE)
     hash: Any = field(default_factory=dataclasses._MISSING_TYPE)
     compare: Any = field(default_factory=dataclasses._MISSING_TYPE)

serde/de.py

@@ -899,6 +899,10 @@ def to_iter_arg(f: DeField, *args, **kwargs) -> DeField:
     return f
 
 
+def renderable(f: DeField) -> bool:
+    return f.init
+
+
 def render_from_iter(cls: Type[Any], custom: Optional[DeserializeFunc] = None, type_check: TypeCheck = NoCheck) -> str:
     template = """
 def {{func}}(cls=cls, maybe_generic=None, data=None, reuse_instances = {{serde_scope.reuse_instances_default}}):
@@ -926,7 +930,8 @@ def {{func}}(cls=cls, maybe_generic=None, data=None, reuse_instances = {{serde_s
     env = jinja2.Environment(loader=jinja2.DictLoader({'iter': template}))
     env.filters.update({'rvalue': renderer.render})
     env.filters.update({'arg': to_iter_arg})
-    res = env.get_template('iter').render(func=FROM_ITER, serde_scope=getattr(cls, SERDE_SCOPE), fields=defields(cls))
+    fields = list(filter(renderable, defields(cls)))
+    res = env.get_template('iter').render(func=FROM_ITER, serde_scope=getattr(cls, SERDE_SCOPE), fields=fields)
 
     if renderer.import_numpy:
         res = "import numpy\n" + res
@@ -973,8 +978,9 @@ def {{func}}(cls=cls, maybe_generic=None, data=None,
     env = jinja2.Environment(loader=jinja2.DictLoader({'dict': template}))
     env.filters.update({'rvalue': renderer.render})
     env.filters.update({'arg': functools.partial(to_arg, rename_all=rename_all)})
+    fields = list(filter(renderable, defields(cls)))
     res = env.get_template('dict').render(
-        func=FROM_DICT, serde_scope=getattr(cls, SERDE_SCOPE), fields=defields(cls), type_check=type_check
+        func=FROM_DICT, serde_scope=getattr(cls, SERDE_SCOPE), fields=fields, type_check=type_check
     )
 
     if renderer.import_numpy:

tests/common.py

@@ -92,6 +92,7 @@ def toml_not_supported(se, de, opt) -> bool:
     param(data.Pri(10, 'foo', 100.0, True), Optional[data.Pri]),
     param(None, Optional[data.Pri], toml_not_supported),
     param(data.Recur(data.Recur(None, None, None), None, None), data.Recur, toml_not_supported),
+    param(data.Init(1), data.Init),
     param(10, NewType('Int', int)),  # NewType
     param({'a': 1}, Any),  # Any
     param(GenericClass[str, int]('foo', 10), GenericClass[str, int]),  # Generic

tests/data.py

@@ -2,7 +2,7 @@
 from dataclasses import dataclass
 from typing import Dict, List, Optional, Tuple
 
-from serde import serde
+from serde import field, serde
 
 from . import imported
 
@@ -257,3 +257,13 @@ class Recur:
 NESTED_PRILIST = ([INT], [STR], [FLOAT], [BOOL])
 
 NESTED_PRILIST_TUPLE = ([(10,)], [('foo',)], [(100.0,)], [(True,)])
+
+
+@dataclass
+@serde
+class Init:
+    a: int
+    b: int = field(init=False)
+
+    def __post_init__(self) -> None:
+        self.b = self.a * 10