-
Notifications
You must be signed in to change notification settings - Fork 30
Description
Hi Team,
Thank you for your patience throughout this provider review process. We have outlined a few more items of feedback that should be address before moving on to the provider release. If you have any questions regarding this feedback, let me know.
-
In the providers website documentation index page argument reference, the access_key and secret_key variables are listed as optional, if I'm not confused, these variables should be listed as
Required
. -
On the Instance resource documentation page, the argument references for variables with a default value should document that value. Specially for the CPU, Memory, and Class variables, as well the
keypair_id
argument is listed as Required but is defined in the provider code as Optional. -
On the Tag resource docs , could you add the
DEFAULT_TAG_COLOR
env variable to thecolor
argument reference. -
In the VPC resource documentation, can you list the default value for the
type
argument? -
The last item is to add more debug statements throughout the provider. Ideally we would like to have two [INFO] statements during each resource operation. This is not a hard requirement, but highly suggested.
These issue should take too long to address. Once complete we can move forward to the ingress and release process of this provider.
Best,
Chris