adds option for mermaidjs version #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. But this PR introduces removing the copy button, right? It's not good. We want to fix the problem without doing it. cc: @ShortArrow |
|
@yusukebe I completely agree :). I just wasn't sure if you were up for any changes. I can work on a "real" fix. |
erik-nilcoast
commented
Mar 5, 2025
| repo="yusukebe/gh-markdown-preview" | ||
| tag="v1.10.0" | ||
| repo="nilcoast/gh-markdown-preview" | ||
| tag="master" |
There was a problem hiding this comment.
This will need to be set back as well
erik-nilcoast
commented
Mar 5, 2025
| @@ -143,25 +143,6 @@ | |||
| mermaid.run({ | |||
| querySelector: 'div.highlight-source-mermaid > pre', | |||
| }); | |||
| const copyIcon= `<svg class="copy-icon" aria-hidden="true" fill="none" height="18" shape-rendering="geometricPrecision" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="1.5" viewBox="0 0 24 24" width="18" style="color:"currentColor";"><path d="M8 17.929H6c-1.105 0-2-.912-2-2.036V5.036C4 3.91 4.895 3 6 3h8c1.105 0 2 .911 2 2.036v1.866m-6 .17h8c1.105 0 2 .91 2 2.035v10.857C20 21.09 19.105 22 18 22h-8c-1.105 0-2-.911-2-2.036V9.107c0-1.124.895-2.036 2-2.036z"></path></svg>`; | |||
There was a problem hiding this comment.
TODO: make this work with the copy/pasta buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.