-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong regex for wal retention #1026
base: master
Are you sure you want to change the base?
Conversation
I also was wondering why the script does not use following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new version of wal-g uses the header name "backup_name" instead of "name". The regex script should be modified to adapt to this
Isn't this going to break |
@bo0ts @emrah83 I updated my regex to be backwards compatible with wal-e. The regex script already has been updated, I think, given that you are referring to this script. |
any chance this would get approved and merged, we're facing also the same issue and tested that this fixes the issue |
If this is already touched, can we discuss if there is an option to have |
@Yingrjimsch I'd advise you to create a separate issue for this :) |
I'd like to see this merged asap, because I think it will take some time to get the version of spilo bumped on the operator, might want to use a custom build for the time being. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This change has better be merged asap because we cannot tolerate backup files to accumulate infinitely.
Fixes #1015
Credits to @andrewfung729 for providing the fix.
Created a PR out of this because I also encountered this issue and needed a fix relatively quickly.
For the maintainers, could you give an estimate on when spilo gets released and when the postgres operator is also bumped? If this could take a while, I may create my own monkey patch until this is released.
Thanks!