-
Notifications
You must be signed in to change notification settings - Fork 47
Open
Labels
bugSomething isn't workingSomething isn't workingzarr-pythonRelevant to zarr-python upstreamRelevant to zarr-python upstream
Milestone
Description
We are apparently still vendoring some code from zarr-python, even though a while ago we added an explicit dependency on it (in #482). That vendored code should have been removed then in favour of directly importing things.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingzarr-pythonRelevant to zarr-python upstreamRelevant to zarr-python upstream
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
TomNicholas commentedon Jun 17, 2025
This came up when I got this error trying to run tests locally
But actually this might be related to the zarr v3 dtypes refactor?
maxrjones commentedon Jun 18, 2025
💯 agree on removing the vendored metadata code.
I think @norlandrhagen vendored https://github.com/zarr-developers/VirtualiZarr/blob/develop/virtualizarr/vendor/zarr/core/common.py to use a private function which we cannot rely on directly. So it might need to stay unless we find a better solution for https://discourse.pangeo.io/t/async-and-sync-interfaces/5190.