Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_sqlite: Fix select_spendable_notes to not ignore the sources parameter #1260

Closed
str4d opened this issue Mar 12, 2024 · 0 comments · Fixed by #1530
Closed

zcash_client_sqlite: Fix select_spendable_notes to not ignore the sources parameter #1260

str4d opened this issue Mar 12, 2024 · 0 comments · Fixed by #1530

Comments

@str4d
Copy link
Contributor

str4d commented Mar 12, 2024

This is ignoring the _sources parameter to select_spendable_notes, and always selecting from both pools. It happens to cause no bugs because zcash_client_backend hard-codes both pools as sources if the feature flags are enabled, but we should fix this anyway.

Originally posted by @str4d in #1182 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nuttycom @daira @str4d