Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easier math in reStructuredText #953

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Easier math in reStructuredText #953

wants to merge 5 commits into from

Conversation

daira
Copy link
Collaborator

@daira daira commented Nov 8, 2024 •
edited
Loading

The $...$ syntax can now be (and is) used in rST, except in tables. fixes #952

The reason why it doesn't work in tables is that replacing $...$ with :math:`...` throws off the column-sensitive table markup. Things like that are why column-sensitive markup is a bad idea.

@daira
Copy link
Collaborator Author

daira commented Nov 8, 2024

This should be merged after #951.

@daira daira marked this pull request as draft November 8, 2024 14:32
@daira daira marked this pull request as ready for review November 8, 2024 20:12
@daira daira requested a review from str4d November 8, 2024 20:15
@daira
Support $...$ for inline math in reStructuredText.
863db74 
Signed-off-by: Daira-Emma Hopwood <[email protected]>
@daira
Use $...$ for inline math in existing reStructuredText ZIPs.
24bf0f8 
Signed-off-by: Daira-Emma Hopwood <[email protected]>
@daira
ZIP 225: use math in some tables.
fa9f612 
Signed-off-by: Daira-Emma Hopwood <[email protected]>
@daira
Re-render.
03809fb 
Signed-off-by: Daira-Emma Hopwood <[email protected]>
@daira
CSS: Make the style of reference links and references (almost) consis…
4e905e4 
…tent

between Markdown and reStructuredText.

Signed-off-by: Daira-Emma Hopwood <[email protected]>
@daira daira requested a review from nuttycom November 8, 2024 23:10
@daira
Copy link
Collaborator Author

daira commented Nov 8, 2024 •
edited
Loading

For review, note that the third commit, which uses $...$ in existing ZIPs, has very little effect on the rendering. So contrary to most PRs, here you want to pay more attention to the rendering commit than to that one. Also check how references actually look after the CSS changes (it might vary between browsers; I only tested Firefox).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d Awaiting requested review from str4d

@nuttycom nuttycom Awaiting requested review from nuttycom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make $...$ work in reStructuredText ZIPs
1 participant
@daira