Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maint]: missing lib function #666

Open
Svartorm opened this issue Aug 12, 2024 · 0 comments
Open

[maint]: missing lib function #666

Svartorm opened this issue Aug 12, 2024 · 0 comments

Comments

@Svartorm
Copy link

Svartorm commented Aug 12, 2024

Summary

I have just newly pick up zinit but while making the swap from OMZ, i came across an issue regarding the web-search plugin.
Using the web_search() function defined return some missing code :

$ ddg thisisawebsearch
zsh: command not found: omz_urlencode
zsh: command not found: open_command

Note: ddg is an alias for web_search duckduckgo

Proposed fix

I have manually looked into the plugin's code and search for the missing functions omz_urlencode() and open_command() and found them in the file function.zsh (link) in the lib folder of OMZ.
Getting that file and sourcing it patched the error.

I do not have any knowledge of how many OMZ plugin use functions from its lib like that nor to what extent the zinit project could suffer from copying those lib file but it might be an option to consider to fully support OMZ plugins out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant