Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: zinit update is running zinit self-update #676

Open
1 task done
YellowPluff opened this issue Oct 21, 2024 · 1 comment
Open
1 task done

[bug]: zinit update is running zinit self-update #676

YellowPluff opened this issue Oct 21, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@YellowPluff
Copy link

What happened?

Per the README and other documentation that I can find, zinit update is supposed to update the plugins and snippets while zinit self-update is supposed to update zinit itself.

Steps to reproduce

  1. Have a basic .zshrc where line 1 is source zinit.zsh
  2. Line 2 is zinit update --all --parallel 30 --reset --quiet
  3. Line 3 is zinit light zdharma-continuum/fast-syntax-highlighting

Relevant output

[self-update] updating zinit repository
[self-update] fetching latest changes from main branch

Screenshots and recordings

No response

Operating System & Version

OS: darwin24.0 | Vendor: apple | Machine: x86_64 | CPU: arm64 | Processor: arm | Hardware: arm64

Zsh version

zsh 5.9 (arm64-apple-darwin24.0)

Terminal emulator

xterm-256color (using iTerm)

If using WSL on Windows, which version of WSL

None

Additional context

This is a very very basic .zshrc file to experiment with. One of two things is happening here and I would like to understand which it is..

  1. A bug is here and zinit update is not supposed to be running zinit self-update
  2. zinit update is supposed to do a zinit self-update and the documentation is either misleading, or wrong.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@YellowPluff YellowPluff added the bug Something isn't working label Oct 21, 2024
@YellowPluff
Copy link
Author

At the time of this writing, I tracked it down in the code. In zinit.zsh on line 2965, you're calling .zinit-update-or-status-all. Per that function from zinit-autoload.zsh, line 4 of the function calls .zinit-self-update -q. Per the blame log, this commit is when that line of code was last touched but that isn't when this behavior was introduced. So this behavior has been there awhile and I'm trying to understand why. Please advise. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants