Skip to content

Tracking Issue: Extensions using extension.json #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
37 tasks
maxdeviant opened this issue Feb 23, 2025 · 12 comments
Open
37 tasks

Tracking Issue: Extensions using extension.json #2104

maxdeviant opened this issue Feb 23, 2025 · 12 comments

Comments

@maxdeviant
Copy link
Member

maxdeviant commented Feb 23, 2025

This is a tracking issue for extensions still using the extension.json manifest format instead of extension.toml.

Extensions using extension.json

@sigmaSd
Copy link
Contributor

sigmaSd commented Mar 6, 2025

I run a bot script, to open a PR with the needed changes for all the above repos, hopefully this make it easier and motivate the owners to migrate.
https://github.com/sigmaSd/botfixzed/blob/master/bot.ts

@maxdeviant
Copy link
Member Author

I run a bot script, to open a PR with the needed changes for all the above repos, hopefully this make it easier and motivate the owners to migrate. https://github.com/sigmaSd/botfixzed/blob/master/bot.ts

The script should also remove the extension.json in the PRs that it opens.

We don't want to end up with a bunch of extensions that have both an extension.toml and and extension.json, which seems to be what is happening.

@sigmaSd
Copy link
Contributor

sigmaSd commented Mar 7, 2025

Yes because I wanted to do the least modifications possible, and noticed in testing that zed prioritize extension.toml that's why I thought its not that important.

@maxdeviant
Copy link
Member Author

Yes because I wanted to do the least modifications possible, and noticed in testing that zed prioritize extension.toml that's why I thought its not that important.

Yes, but we want the extension.json gone. That is the whole point of this migration.

And the extension CI will fail when these authors go to publish a new version if they have both.

@sigmaSd
Copy link
Contributor

sigmaSd commented Mar 7, 2025

I see, I'll update the PRs then.

@maxdeviant
Copy link
Member Author

@sigmaSd Some of the PRs have other issues as well.

The one for zed-fish contained an extension.toml that was invalid and did not make the necessary removals to other files in the repo: hasit/zed-fish#11

@sigmaSd
Copy link
Contributor

sigmaSd commented Mar 7, 2025

For that extension in particular , I did test manually and I noticed the grammar, but I left it because the extension still works, the PRs were meant as a minimum working changes while the author do the clean up and gets motivated to update.

I have the script running now pushing a commit to remove extension.json to all the open prs it made. but I'm not going to make it do more, the extension author have to test it manually and do the needed cleanup.

@sigmaSd
Copy link
Contributor

sigmaSd commented Mar 7, 2025

Actually the grammars changes seems straight forward, maybe I'll add that

@sigmaSd
Copy link
Contributor

sigmaSd commented Mar 7, 2025

@maxdeviant I'll update the script with you recommendations, currently this is what I'm going to do

  • remove grammar = type
  • remove grammer folder
  • remove languages key
  • if there is already a [grammar] dict remove it
  • add grammar to gitignore

@sigmaSd
Copy link
Contributor

sigmaSd commented Mar 7, 2025

I update all the pr as discussed, is there more feedback ?

@maxdeviant
Copy link
Member Author

I update all the pr as discussed, is there more feedback ?

Thank you! I think that should be all that is needed.

Sorry if I came off a bit blunt, I just want to make sure that we're helping out maintainers and not creating more work for them.

I do appreciate you helping out with this migration 🙂

@sigmaSd
Copy link
Contributor

sigmaSd commented Mar 7, 2025

No problem, that makes sense thanks as well

notpeter pushed a commit that referenced this issue May 31, 2025
Uses the new `extension.toml` format for the extension

Fixes my extension for #2104 

Does the folder name need to be the same as the extension ID? If so, I
can update that
athxx pushed a commit to athxx/extensions that referenced this issue Jun 6, 2025
Uses the new `extension.toml` format for the extension

Fixes my extension for zed-industries#2104 

Does the folder name need to be the same as the extension ID? If so, I
can update that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants