Don't show current project in recent projects.

[VladasZ]

Recent projects is very cool feature. But by default the first project in the recent list is current project which is a bit inconvenient in my opinion. I need to press another button to switch to last opened project. Why would anyone want to open the project which is already in front of you? This action does nothing.

I think it is better to hide current project from this list.

I implemented a very simple skip here:
VladasZ@639164d

And now recent project list doesn't show current project.

I want to discuss if this is a good idea in general.
Or maybe it is better to put current project at the end of the list but still display it?
Or this should be a new option?

[SomeoneToIgnore]

The idea looks nice, but I think we have to do more and remove all related rendering logic in

zed/crates/recent_projects/src/recent_projects.rs

Line 397 in 230b10d

let is_current_workspace = self.is_current_workspace(*workspace_id, cx);

Also .skip(1) looks dangerous, I would use a filter with the is_current_workspace function instead.

[VladasZ]

Yeah I agree. Here is the better implementation: VladasZ@168cebf

[SomeoneToIgnore]

Style-wise, I think it's more readable when split into .filter().map() chain, but otherwise looks like a PR to me.
As a bonus change since we're touching that line, one could also replace &self.workspaces[hit.candidate_id]; with .get()? to be 100% sure that Zed won't panic here ever.

[VladasZ]

Okay I'll do that and create a PR.

[VladasZ]

@SomeoneToIgnore : #12502